ro added a comment.
In https://reviews.llvm.org/D40903#998474, @alekseyshl wrote:
> Rainer, check https://reviews.llvm.org/rC324302 out, you probably want to add
> test cases for Solaris to test/Driver/sanitizer-ld.c too.
Sorry about that! I certainly will, but it'll be some time because I'm
alekseyshl added a comment.
Rainer, check https://reviews.llvm.org/rC324302 out, you probably want to add
test cases for Solaris to test/Driver/sanitizer-ld.c too.
Repository:
rC Clang
https://reviews.llvm.org/D40903
___
cfe-commits mailing list
This revision was automatically updated to reflect the committed changes.
Closed by commit rC324296: [Sanitizers] Basic Solaris sanitizer support (PR
33274) (authored by alekseyshl, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D40903
Files:
include/clang/Driver/ToolChain.h
ro added a comment.
Could anyone please commit this for me?
Thanks.
Rainer
Repository:
rC Clang
https://reviews.llvm.org/D40903
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ro added a comment.
There are two issues before the patch can be commited:
- It depends on https://reviews.llvm.org/D35755 which needs minor changes.
- I'm currently working with an experimental version of Solaris ld that *does*
support generation of __start___sancov_guards etc. labels. This wi
ro updated this revision to Diff 127499.
ro marked an inline comment as done.
ro added a comment.
Reworded comment.
Repository:
rC Clang
https://reviews.llvm.org/D40903
Files:
include/clang/Driver/ToolChain.h
lib/Driver/ToolChain.cpp
lib/Driver/ToolChains/CommonArgs.cpp
lib/Driver/To
ro marked an inline comment as done.
ro added inline comments.
Comment at: lib/Driver/ToolChains/CommonArgs.cpp:528
StringRef Sanitizer) {
+ // Solaris ld doesn't need this. Inhibit use of non-existant
+ // --export-dynamic.
---
alekseyshl accepted this revision.
alekseyshl added inline comments.
This revision is now accepted and ready to land.
Comment at: lib/Driver/ToolChains/CommonArgs.cpp:528
StringRef Sanitizer) {
+ // Solaris ld doesn't need this. Inhibit use
ro added inline comments.
Comment at: lib/Driver/ToolChains/CommonArgs.cpp:528
StringRef Sanitizer) {
+ // Solaris ld doesn't need this. Inhibit use of non-existant
+ // --export-dynamic.
alekseyshl wrote:
> Can you elabora
alekseyshl added inline comments.
Comment at: lib/Driver/ToolChains/CommonArgs.cpp:528
StringRef Sanitizer) {
+ // Solaris ld doesn't need this. Inhibit use of non-existant
+ // --export-dynamic.
Can you elaborate why Solar
ro added inline comments.
Comment at: lib/Driver/ToolChains/CommonArgs.cpp:684
if (AddExportDynamic)
-CmdArgs.push_back("-export-dynamic");
+CmdArgs.push_back("--export-dynamic");
alekseyshl wrote:
> If it does not exist on Solaris, why change it the
alekseyshl added inline comments.
Comment at: lib/Driver/ToolChains/CommonArgs.cpp:684
if (AddExportDynamic)
-CmdArgs.push_back("-export-dynamic");
+CmdArgs.push_back("--export-dynamic");
If it does not exist on Solaris, why change it then? For the c
ro created this revision.
ro added a project: Sanitizers.
Herald added subscribers: fedor.sergeev, jyknight.
This patch (on top of https://reviews.llvm.org/D35755) provides the clang side
necessary
to enable the Solaris port of the sanitizers implemented by
https://reviews.llvm.org/D40898,
https
13 matches
Mail list logo
