compnerd added a comment.
https://reviews.llvm.org/D42768 adds the `__swift_cc` in the right location and
detangles correctly with `undname` as well.
Repository:
rC Clang
https://reviews.llvm.org/D40929
___
cfe-commits mailing list
troughton marked an inline comment as done.
troughton added a comment.
> Which, I think is just adding something wacky like `@swiftcc@__Swift@@` which
> would demangle as `__Swift::swiftcc` if the demangler expected an NNS there.
> Of course, it doesn't, so it won't demangle, but at least you
rnk added a comment.
@compnerd's suggestion is still a decent one: https://reviews.llvm.org/D31372
Which, I think is just adding something wacky like `@swiftcc@__Swift@@` which
would demangle as `__Swift::swiftcc` if the demangler expected an NNS there. Of
course, it doesn't, so it won't
rjmccall added reviewers: rnk, majnemer.
rjmccall added a comment.
Reid, David, do you have a recommendation about the right way to support
non-MS-supported CCs here?
Repository:
rC Clang
https://reviews.llvm.org/D40929
___
cfe-commits mailing
troughton updated this revision to Diff 125847.
troughton added a comment.
Add back a mistakenly removed default case.
Repository:
rC Clang
https://reviews.llvm.org/D40929
Files:
lib/AST/MicrosoftMangle.cpp
Index: lib/AST/MicrosoftMangle.cpp
smeenai added a comment.
Patch is missing context.
Comment at: lib/AST/MicrosoftMangle.cpp:2133
+ llvm::errs() << "Unsupported CC for mangling: " << CC << ".\n";
case CC_Win64:
case CC_X86_64SysV:
You still need the default label, right?
troughton created this revision.
troughton added a project: clang.
Herald added a subscriber: cfe-commits.
Following discussion on the [[
https://lists.swift.org/pipermail/swift-dev/Week-of-Mon-20171204/006123.html |
swift-dev mailing list] and on a pull request for swift-clang
