mclow.lists accepted this revision.
mclow.lists added a comment.
This revision is now accepted and ready to land.
These look fine to me. Thanks for the attention to detail.
https://reviews.llvm.org/D41030
___
cfe-commits mailing list
mclow.lists added a comment.
> Avoid MSVC "warning C4293: '<<': shift count negative or too big, undefined
> behavior".
> MSVC sees (1ULL << N) and warns - being guarded by const bool canFit is
> insufficient. A small change to the code
Your compiler needs to either (a) get much smarter
STL_MSFT created this revision.
[libcxx] [test] Fix MSVC warnings, null pointer deref.
test/std/algorithms/alg.modifying.operations/alg.generate/generate_n.pass.cpp
Silence MSVC warning C4244. This is expected when passing
floating-point values for size.
