This revision was automatically updated to reflect the committed changes.
Closed by commit rC320730: [CodeGen][X86] Implement
_InterlockedCompareExchange128 intrinsic (authored by rnk, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D41032?vs=126641=126997#toc
Repository:
colden added a comment.
Thanks Reid! Would you mind submitting this for me?
https://reviews.llvm.org/D41032
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
https://reviews.llvm.org/D41032
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
colden marked an inline comment as done.
colden added inline comments.
Comment at: llvm/tools/clang/lib/CodeGen/CGBuiltin.cpp:8439
+
+llvm::Type *Int128Ty = llvm::IntegerType::get(getLLVMContext(), 128);
+llvm::Type *Int128PtrTy = Int128Ty->getPointerTo();
colden updated this revision to Diff 126641.
colden added a comment.
llvm::IntegerType::get(getLLVMContext(), 128) -> Builder.getInt128Ty()
https://reviews.llvm.org/D41032
Files:
llvm/tools/clang/include/clang/Basic/BuiltinsX86_64.def
llvm/tools/clang/lib/CodeGen/CGBuiltin.cpp
majnemer added inline comments.
Comment at: llvm/tools/clang/lib/CodeGen/CGBuiltin.cpp:8439
+
+llvm::Type *Int128Ty = llvm::IntegerType::get(getLLVMContext(), 128);
+llvm::Type *Int128PtrTy = Int128Ty->getPointerTo();
Builder.getInt128Ty()
colden updated this revision to Diff 126634.
colden retitled this revision from "[CodeGen] Implement
_InterlockedCompareExchange128 intrinsic" to "[CodeGen][X86] Implement
_InterlockedCompareExchange128 intrinsic".
colden added a comment.
Moved implementation to X86_64 specific code, as
