This revision was automatically updated to reflect the committed changes.
Closed by commit rC320235: [driver][darwin] Refactor the target selection code,
NFC (authored by arphaman).
Repository:
rC Clang
https://reviews.llvm.org/D41035
Files:
lib/Driver/ToolChains/Darwin.cpp
steven_wu added a comment.
LGTM.
Repository:
rC Clang
https://reviews.llvm.org/D41035
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
arphaman updated this revision to Diff 126222.
arphaman marked an inline comment as done.
arphaman added a comment.
Add static_assert
Repository:
rC Clang
https://reviews.llvm.org/D41035
Files:
lib/Driver/ToolChains/Darwin.cpp
lib/Driver/ToolChains/Darwin.h
dexonsmith added a comment.
This seems correct to me. I wouldn't mind having someone else back me up
though.
Also, I have a suggestion for a `static_assert`.
Comment at: lib/Driver/ToolChains/Darwin.cpp:1334-1339
+ const char *EnvVars[Darwin::LastDarwinPlatform + 1] = {
+
arphaman created this revision.
This patch refactors the target selection in Darwin's driver.
Firstly, the simulator variant of Darwin's platforms is removed in favor of a
new environment field.
Secondly, the code that selects the platform and the version is split into 4
different functions
