george.karpenkov added a comment.
Also loops created with gotos should also be supported (e.g. by finding
backedges), but that could be done in a different patch.
https://reviews.llvm.org/D41150
___
cfe-commits mailing list
george.karpenkov added a comment.
I would prefer a more detailed CFG element with more meta-information about
nested loop, but this is a good starting point.
https://reviews.llvm.org/D41150
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
szepet added a comment.
Herald added a reviewer: george.karpenkov.
ping
https://reviews.llvm.org/D41150
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
szepet updated this revision to Diff 130505.
szepet added a comment.
> I essentially have one question at a glance - for loop counter variables,
> don't we want LoopEntrance be before the initialization?
I guess this would just make too much sense. Done that.
Additionally, handle the cases
NoQ added a comment.
(edited my comment: fixed the suggested change to mention the right block)
https://reviews.llvm.org/D41150
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
NoQ added a comment.
Because it wasn't immediately obvious to me how to apply both this patch and
https://reviews.llvm.org/D39398 (there are a couple of minor conflicts between
them), i wanted to post a few pictures for the reference, because
`debug.ViewCFG` graphs are much easier to
szepet updated this revision to Diff 127894.
szepet marked an inline comment as done.
szepet added a comment.
Comment added to LoopEntrance CFGElement.
https://reviews.llvm.org/D41150
Files:
include/clang/Analysis/CFG.h
lib/Analysis/CFG.cpp
lib/StaticAnalyzer/Core/PathDiagnostic.cpp
dkrupp added inline comments.
Comment at: include/clang/Analysis/CFG.h:179
/// entered.
+class CFGLoopEntrance : public CFGElement {
+public:
This comment refers to the CFGLoopExit class. Please add a separate explaining
comment to the CFGLoopEntrance.
szepet created this revision.
szepet added reviewers: dcoughlin, zaks.anna, NoQ, rsmith.
Herald added subscribers: dkrupp, a.sidorin, baloghadamsoftware, whisperity.
Adding LoopEntrance as a new CFGElement to the CFG.
This element is added as the last element of the CFGBlock just before the loop
