This revision was automatically updated to reflect the committed changes.
Closed by commit rL320701: [clangd] Add a FileSymbols container that manages
symbols from multiple files. (authored by ioeric, committed by ).
Repository:
rL LLVM
https://reviews.llvm.org/D41232
Files:
ioeric updated this revision to Diff 126944.
ioeric added a comment.
- fix HEADER_GUARD
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D41232
Files:
clangd/CMakeLists.txt
clangd/index/FileSymbols.cpp
clangd/index/FileSymbols.h
unittests/clangd/CMakeLists.txt
ioeric updated this revision to Diff 126943.
ioeric marked 2 inline comments as done.
ioeric added a comment.
- Address review comments
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D41232
Files:
clangd/CMakeLists.txt
clangd/index/FileSymbols.cpp
sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.
Comment at: clangd/index/FileSymbols.h:39
+
+ /// \brief Removes snapshots of \p Path.
+ void remove(PathRef Path);
Consider just accepting
ioeric created this revision.
ioeric added a reviewer: sammccall.
Herald added subscribers: cfe-commits, ilya-biryukov, mgorny, klimek.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D41232
Files:
clangd/CMakeLists.txt
clangd/index/FileSymbols.cpp
clangd/index/FileSymbols.h
