This revision was automatically updated to reflect the committed changes.
Closed by commit rL321174: [Frontend] Handle skipped bodies in template
instantiations (authored by ibiryukov, committed by ).
Repository:
rL LLVM
https://reviews.llvm.org/D41237
Files:
sepavloff accepted this revision.
sepavloff added a comment.
This revision is now accepted and ready to land.
LGTM.
Thanks!
Repository:
rC Clang
https://reviews.llvm.org/D41237
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
ilya-biryukov updated this revision to Diff 127473.
ilya-biryukov marked an inline comment as done.
ilya-biryukov added a comment.
- Added a check for null in ActOnSkippedBody
Repository:
rC Clang
https://reviews.llvm.org/D41237
Files:
lib/Sema/SemaDecl.cpp
ilya-biryukov added inline comments.
Comment at: lib/Sema/SemaDecl.cpp:12184
Decl *Sema::ActOnSkippedFunctionBody(Decl *Decl) {
- if (FunctionDecl *FD = dyn_cast_or_null(Decl))
+ if (FunctionDecl *FD = Decl->getAsFunction())
FD->setHasSkippedBody();
ilya-biryukov added inline comments.
Comment at: lib/Sema/SemaDecl.cpp:12184
Decl *Sema::ActOnSkippedFunctionBody(Decl *Decl) {
- if (FunctionDecl *FD = dyn_cast_or_null(Decl))
+ if (FunctionDecl *FD = Decl->getAsFunction())
FD->setHasSkippedBody();
sepavloff added inline comments.
Comment at: lib/Sema/SemaDecl.cpp:12184
Decl *Sema::ActOnSkippedFunctionBody(Decl *Decl) {
- if (FunctionDecl *FD = dyn_cast_or_null(Decl))
+ if (FunctionDecl *FD = Decl->getAsFunction())
FD->setHasSkippedBody();
In the
ilya-biryukov created this revision.
ilya-biryukov added reviewers: sepavloff, bkramer.
- Fixed an assert in Sema::InstantiateFunctionDefinition and added support for
instantiating a function template with skipped body.
- Properly call setHasSkippedBody for FunctionTemplateDecl passed to
