dblaikie added a comment.
I've pushed this further - it builds now & has no fallback in libBasic to the
old behavior/table.
One remaining thing I'm unsure about is the table of DIAG_START_* values. Do
you think this is OK/good to leave hardcoded in diagnostics? Should I somehow
remove the
dblaikie added a comment.
Updated with a functional implementation - a few points:
- Some tests could use only the Common diagnostics (see one of the intermediate
changes where I moved those tests over to use all diagnostics) except for the
tablegen required for the diagnostic groups makes
craig.topper added inline comments.
Comment at: lib/Basic/DiagnosticIDs.cpp:58
/// GetDiagInfo - Return the StaticDiagInfoRec entry for the specified DiagID,
/// or null if the ID is invalid.
This comment is out of date with the struct being renamed.
rsmith added a comment.
Yes, I think this is the right general direction -- in general, moving towards
making clang's diagnostic infrastructure a reusable component that isn't tied
to a particular diagnostics table, and in particular moving the knowledge of
the complete set of diagnostics and
dblaikie created this revision.
dblaikie added a reviewer: rsmith.
Herald added subscribers: cfe-commits, klimek.
This goes part-way down the path of moving the actual diagnostics out of
Clang's Basic library into the respective libraries that use those diagnostics.
The end goal would be that a
