This revision was automatically updated to reflect the committed changes.
Closed by commit rL321351: [CodeGen] Support generation of TBAA info in the new
format (authored by kosarev, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D41394?vs=127838&id=127993#toc
Repository:
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
That's great, thanks. LGTM.
https://reviews.llvm.org/D41394
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cg
kosarev updated this revision to Diff 127838.
kosarev added a comment.
Updated as suggested.
https://reviews.llvm.org/D41394
Files:
lib/CodeGen/CodeGenTBAA.cpp
test/CodeGen/tbaa.cpp
Index: test/CodeGen/tbaa.cpp
===
--- test/Co
rjmccall added a comment.
You can pass multiple -check-prefix arguments to FileCheck and it'll match all
of them. You can use that to make your test change simpler: make the existing
RUN check for both PATH and OLD-PATH and the new RUN check for both PATH and
NEW-PATH, then change all the exis
kosarev updated this revision to Diff 127722.
kosarev added a comment.
Added tests.
https://reviews.llvm.org/D41394
Files:
lib/CodeGen/CodeGenTBAA.cpp
test/CodeGen/tbaa.cpp
Index: test/CodeGen/tbaa.cpp
===
--- test/CodeGen/tba
hfinkel added a comment.
In https://reviews.llvm.org/D41394#959715, @rjmccall wrote:
> Rewriting some of the most basic tests would be fine. Please either use new
> FileCheck lines or clone the existing tests, since we don't really know how
> long this transition will last.
+1
Otherwise, th
rjmccall added a comment.
Rewriting some of the most basic tests would be fine. Please either use new
FileCheck lines or clone the existing tests, since we don't really know how
long this transition will last.
Repository:
rL LLVM
https://reviews.llvm.org/D41394
_
kosarev added a comment.
There are more tests that we will need to rewrite during migration to the new
format than I think we could handle with a single patch. I was going to address
them with separate patches. Or, I can rewrite some most basic of them as part
of this patch.
Repository:
rL
rjmccall added a comment.
Tests?
Repository:
rL LLVM
https://reviews.llvm.org/D41394
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
kosarev created this revision.
kosarev added reviewers: rjmccall, hfinkel.
kosarev added a project: clang.
Now that the MDBuilder helpers generating TBAA type and access descriptors in
the new format are in place, we can teach clang to use them when requested.
Repository:
rL LLVM
https://rev
10 matches
Mail list logo