MaskRay added inline comments.
Herald added a subscriber: ributzka.
Herald added a project: All.
Comment at: cfe/trunk/lib/Driver/ToolChains/Darwin.cpp:1545
+std::string TargetArg = OSTarget->getAsString(Args, Opts);
+
This revision was automatically updated to reflect the committed changes.
Closed by commit rL321145: [darwin][driver] Warn about mismatching
-os-version-min rather than (authored by arphaman, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D41425?vs=127637=127648#toc
arphaman added inline comments.
Comment at: lib/Driver/ToolChains/Darwin.cpp:1536
+ Driver::GetReleaseVersion(OSVersionArgTarget->getOSVersion(),
+ ArgMajor, ArgMinor, ArgMicro, HadExtra) &&
+ VersionTuple(TargetMajor,
steven_wu added inline comments.
Comment at: lib/Driver/ToolChains/Darwin.cpp:1536
+ Driver::GetReleaseVersion(OSVersionArgTarget->getOSVersion(),
+ ArgMajor, ArgMinor, ArgMicro, HadExtra) &&
+ VersionTuple(TargetMajor,
arphaman added inline comments.
Comment at: lib/Driver/ToolChains/Darwin.cpp:1536
+ Driver::GetReleaseVersion(OSVersionArgTarget->getOSVersion(),
+ ArgMajor, ArgMinor, ArgMicro, HadExtra) &&
+ VersionTuple(TargetMajor,
steven_wu accepted this revision.
steven_wu added a comment.
Just a small suggestion. Looks good otherwise.
Comment at: lib/Driver/ToolChains/Darwin.cpp:1536
+ Driver::GetReleaseVersion(OSVersionArgTarget->getOSVersion(),
+
bob.wilson accepted this revision.
bob.wilson added a comment.
This revision is now accepted and ready to land.
Eventually it would be nice to also warn about redundant -m*-version-min
options, but for now I agree that it would be best to start with warning only
when the options are different.
arphaman created this revision.
arphaman added reviewers: bob.wilson, dexonsmith, steven_wu.
The warning about the superfluous `--version-min` compiler option seems a
little too strong right now. For now we should only warn about
`--version-min` options that specify a different OS version to
