This revision was automatically updated to reflect the committed changes.
Closed by commit rC321778: Replace cp -a in various Clang tests (authored by
hubert.reinterpretcast, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D41545?vs=128584=128586#toc
Repository:
rC Clang
hubert.reinterpretcast updated this revision to Diff 128584.
hubert.reinterpretcast added a comment.
Use cp -R, which is sufficient instead of cp -RPp
Repository:
rC Clang
https://reviews.llvm.org/D41545
Files:
test/Modules/crash-vfs-path-emptydir-entries.m
hubert.reinterpretcast added a comment.
I'll commit with `cp -R` tomorrow then; thanks.
Repository:
rC Clang
https://reviews.llvm.org/D41545
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
bruno accepted this revision.
bruno added a comment.
This revision is now accepted and ready to land.
Hi Hubert,
Thanks for fixing this. `cp -R` is sufficient IMO. LGTM
Repository:
rC Clang
https://reviews.llvm.org/D41545
___
cfe-commits
hubert.reinterpretcast added a comment.
Maybe `cp -R` is sufficient? `cp -RPp` was the just-to-be-safe "minimal change".
Repository:
rC Clang
https://reviews.llvm.org/D41545
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
hubert.reinterpretcast created this revision.
`cp -a` is neither part of POSIX nor the LSB; this patch uses `cp -RPp`, the
nearest equivalent under POSIX.
The tree being copied in each case currently contains only directories and
regular files; so the `-P` is superfluous.
