[PATCH] D41688: [Lex] Fix crash on code completion in comment in included file.

This revision was automatically updated to reflect the committed changes. Closed by commit rC323008: [Lex] Fix crash on code completion in comment in included file. (authored by vsapsai, committed by ). Changed prior to commit: https://reviews.llvm.org/D41688?vs=128480=130710#toc Repository:

[PATCH] D41688: [Lex] Fix crash on code completion in comment in included file.

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. I think that's a sensible fix, thanks! https://reviews.llvm.org/D41688 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D41688: [Lex] Fix crash on code completion in comment in included file.

vsapsai added a comment. A few approaches that I've considered but decided not to pursue: - Change code completion in comment so we don't exit file early but more gracefully. Decided not to do it because I believe early exit is important for code completion performance. And

[PATCH] D41688: [Lex] Fix crash on code completion in comment in included file.

vsapsai created this revision. vsapsai added reviewers: akyrtzi, doug.gregor. Herald added subscribers: kbarton, nemanjai. This fixes PR32732 by updating CurLexerKind to reflect available lexers. We were hitting null pointer in Preprocessor::Lex because CurLexerKind was CLK_Lexer but CurLexer was