This revision was automatically updated to reflect the committed changes.
Closed by commit rL321913: clang-tidy: add IgnoreMacros option to
readability-inconsistent-declaration… (authored by vmiklos, committed by ).
Herald added a subscriber: klimek.
Changed prior to commit:
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
Thus, looks good. Thanks!
https://reviews.llvm.org/D41716
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
alexfh added a comment.
In https://reviews.llvm.org/D41716#967247, @vmiklos wrote:
> In https://reviews.llvm.org/D41716#967237, @lebedev.ri wrote:
>
> > That changes the defaults though. I thought clang-tidy *tried* to produce
> > the same results
> > on different clang-tidy versions with the
vmiklos added a comment.
In https://reviews.llvm.org/D41716#967237, @lebedev.ri wrote:
> That changes the defaults though. I thought clang-tidy *tried* to produce the
> same results
> on different clang-tidy versions with the same `.clang-tidy` config? Or is
> there no such guarantees?
Hmm,
lebedev.ri added a comment.
> And also enable it by default to be consistent with e.g. modernize-use-using.
That changes the defaults though. I thought clang-tidy *tried* to produce the
same results
on different clang-tidy versions with the same `.clang-tidy` config? Or is
there no such
vmiklos created this revision.
vmiklos added reviewers: alexfh, piotrdz.
And also enable it by default to be consistent with e.g. modernize-use-using.
This helps e.g. when running this check on client code where the macro is
provided by the system, so there is no easy way to modify it.
