This revision was automatically updated to reflect the committed changes.
Closed by commit rC322796: [analyzer] operator new: Add a new ProgramPoint for
check::NewAllocator. (authored by dergachev, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D41800
Files:
include/clang/Ana
NoQ added inline comments.
Comment at: test/Analysis/NewDelete-path-notes.cpp:44
// CHECK-NEXT:
-// CHECK-NEXT:line6
+// CHECK-NEXT:line7
// CHECK-NEXT:col3
a.sidorin wrote:
> NoQ wrote:
> > a.sidorin wrote:
> > >
a.sidorin added inline comments.
Comment at: test/Analysis/NewDelete-path-notes.cpp:44
// CHECK-NEXT:
-// CHECK-NEXT:line6
+// CHECK-NEXT:line7
// CHECK-NEXT:col3
NoQ wrote:
> a.sidorin wrote:
> > Not even a minor
NoQ added inline comments.
Comment at: test/Analysis/NewDelete-path-notes.cpp:44
// CHECK-NEXT:
-// CHECK-NEXT:line6
+// CHECK-NEXT:line7
// CHECK-NEXT:col3
a.sidorin wrote:
> Not even a minor concern for this patc
a.sidorin accepted this revision.
a.sidorin added inline comments.
Comment at: test/Analysis/NewDelete-path-notes.cpp:44
// CHECK-NEXT:
-// CHECK-NEXT:line6
+// CHECK-NEXT:line7
// CHECK-NEXT:col3
Not even a minor
NoQ added inline comments.
Comment at: include/clang/Analysis/ProgramPoint.h:592
+ friend class ProgramPoint;
+ PostAllocatorCall() {}
+ static bool isKind(const ProgramPoint &Location) {
xazax.hun wrote:
> Maybe `= default` is getting more canonical within LL
NoQ updated this revision to Diff 129215.
NoQ marked an inline comment as done.
NoQ added a comment.
Fix the comment.
https://reviews.llvm.org/D41800
Files:
include/clang/Analysis/ProgramPoint.h
lib/StaticAnalyzer/Core/CheckerManager.cpp
lib/StaticAnalyzer/Core/CoreEngine.cpp
lib/Static
xazax.hun accepted this revision.
xazax.hun added a comment.
LG!
Comment at: include/clang/Analysis/ProgramPoint.h:592
+ friend class ProgramPoint;
+ PostAllocatorCall() {}
+ static bool isKind(const ProgramPoint &Location) {
Maybe `= default` is getting mor
dcoughlin accepted this revision.
dcoughlin added inline comments.
This revision is now accepted and ready to land.
Comment at: lib/StaticAnalyzer/Core/CheckerManager.cpp:491
NodeBuilder &Bldr, ExplodedNode *Pred) {
// TODO: Does this deserve a custom
NoQ added inline comments.
Comment at: lib/StaticAnalyzer/Core/ExprEngine.cpp:2906-2907
Out << "\\lPostLValue\\l";
+else if (Loc.getAs())
+ Out << "\\lPostAllocatorCall\\l";
{F5743196}
Repository:
rC Clang
https://reviews.llvm.o
NoQ created this revision.
NoQ added reviewers: dcoughlin, xazax.hun, a.sidorin, george.karpenkov, szepet.
Herald added subscribers: cfe-commits, rnkovacs.
This addresses a TODO from https://reviews.llvm.org/D41406. I re-used
`PostImplicitCall` program point when calling the new callback, but it
11 matches
Mail list logo