This revision was automatically updated to reflect the committed changes.
Closed by commit rC322382: [WebAssembly] Support -stdlib=libc++ switch
(authored by sbc, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D41937?vs=129572=129649#toc
Repository:
rC Clang
patcheng added a comment.
Thanks @sbc100.
BTW I don't have commit access. When it's ready to be committed, I would need
help with that.
Thanks
https://reviews.llvm.org/D41937
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
sbc100 added a comment.
lgtm
https://reviews.llvm.org/D41937
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
patcheng updated this revision to Diff 129572.
patcheng edited the summary of this revision.
patcheng added a comment.
Added -lc++abi per @sbc100 's suggestion
https://reviews.llvm.org/D41937
Files:
lib/Driver/ToolChains/WebAssembly.cpp
lib/Driver/ToolChains/WebAssembly.h
patcheng added inline comments.
Comment at: lib/Driver/ToolChains/WebAssembly.cpp:151
+ case ToolChain::CST_Libcxx:
+CmdArgs.push_back("-lc++");
+break;
sbc100 wrote:
> Can you add -lc++abi too? Then I can drop D41966
Sure, but I am not in front of a
sbc100 added inline comments.
Comment at: lib/Driver/ToolChains/WebAssembly.cpp:151
+ case ToolChain::CST_Libcxx:
+CmdArgs.push_back("-lc++");
+break;
Can you add -lc++abi too? Then I can drop D41966
Repository:
rC Clang
dschuff accepted this revision.
dschuff added a comment.
LGTM, but does it need to be rebased after the `-allow-undefined-file` change?
Repository:
rC Clang
https://reviews.llvm.org/D41937
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
sbc100 accepted this revision.
sbc100 added a comment.
This revision is now accepted and ready to land.
Nice. I happened to just upload a similar (but orthogonal) patch:
https://reviews.llvm.org/D41966
Repository:
rC Clang
https://reviews.llvm.org/D41937
patcheng created this revision.
Herald added subscribers: cfe-commits, sunfish, aheejin, jgravelle-google,
sbc100, dschuff, jfb.
Herald added a reviewer: EricWF.
Referenced implementation from Fuchsia and Darwin Toolchain.
Still only support CST_Libcxx.
Now checks that the argument is really
