This revision was automatically updated to reflect the committed changes.
Closed by commit rCXX324596: [libcxx] Avoid spurious construction of valarray
elements (authored by miyuki, committed by ).
Repository:
rCXX libc++
https://reviews.llvm.org/D41992
Files:
include/valarray
mclow.lists accepted this revision.
mclow.lists added a comment.
This revision is now accepted and ready to land.
This LGTM.
Comment at: include/valarray:3728
+{
+__clear();
if (__n)
I thought that you had lost an exception guarantee here, but it
miyuki added a comment.
ping^3
https://reviews.llvm.org/D41992
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
miyuki added a comment.
ping^2
https://reviews.llvm.org/D41992
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
miyuki added a comment.
ping
https://reviews.llvm.org/D41992
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
miyuki created this revision.
miyuki added reviewers: EricWF, mclow.lists.
Currently libc++ implements some operations on valarray by using the
resize method. This method has a parameter with a default value.
Because of this, valarray may spuriously construct and destruct
objects of valarray's
