This revision was not accepted when it landed; it landed in state "Needs
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rL325961: Set Module Metadata "RtLibUseGOT" when
fno-plt is used. (authored by tmsriram, committed by ).
Herald added a subs
On Fri, Feb 23, 2018 at 11:54 AM, Rafael Avila de Espindola
wrote:
> Sriraman Tallam via Phabricator writes:
>> + if (CodeGenOpts.NoPLT) {
>> +getModule().setAvoidPLT();
>> + }
>> +
>
> You don't need the {}.
>
> LGTM with that.
Thanks!
Sri
>
> Cheers,
> Rafael
___
Sriraman Tallam via Phabricator writes:
> + if (CodeGenOpts.NoPLT) {
> +getModule().setAvoidPLT();
> + }
> +
You don't need the {}.
LGTM with that.
Cheers,
Rafael
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-
tmsriram added a comment.
Ping.
https://reviews.llvm.org/D42217
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
tmsriram added a comment.
Ping. This patch goes with https://reviews.llvm.org/D42216, Rafael can you
approve this too if you think it is ok? Thanks.
https://reviews.llvm.org/D42217
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lis
tmsriram updated this revision to Diff 135144.
tmsriram added a comment.
Updated patch.
https://reviews.llvm.org/D42217
Files:
lib/CodeGen/CodeGenModule.cpp
test/CodeGen/noplt.c
Index: test/CodeGen/noplt.c
===
--- test/CodeGe
tmsriram updated this revision to Diff 130500.
tmsriram added a comment.
METADATA tag changed to "RtLibUseGOT". Also see:
https://reviews.llvm.org/D42224/
https://reviews.llvm.org/D42217
Files:
lib/CodeGen/CodeGenModule.cpp
test/CodeGen/noplt.c
Index: test/CodeGen/noplt.c
==
tmsriram created this revision.
tmsriram added reviewers: rnk, rafael.
Set Module Metadata "AvoidPLT" when -fno-plt is used.
Please see:
https://reviews.llvm.org/D42216 for more details.
This allows processing of calls to intrinsics easily.
https://reviews.llvm.org/D42217
Files:
lib/CodeGen