[PATCH] D42225: libcxx: Provide overloads for basic_filebuf::open() et al that take wchar_t* filenames on Windows.

2021-09-24 Thread Martin Storsjö via Phabricator via cfe-commits
mstorsjo added a comment. In D42225#3020688 , @CaseyCarter wrote: > In D42225#2963216 , @ldionne wrote: > >> In D42225#2963190 , @mstorsjo wrote: >> >>> In D42225#2962348

[PATCH] D42225: libcxx: Provide overloads for basic_filebuf::open() et al that take wchar_t* filenames on Windows.

2021-09-24 Thread Casey Carter via Phabricator via cfe-commits
CaseyCarter added a comment. In D42225#2963216 , @ldionne wrote: > In D42225#2963190 , @mstorsjo wrote: > >> In D42225#2962348 , @ldionne wrote: >> >>> @pcc @mstorsjo Are we

[PATCH] D42225: libcxx: Provide overloads for basic_filebuf::open() et al that take wchar_t* filenames on Windows.

2021-08-24 Thread Louis Dionne via Phabricator via cfe-commits
ldionne added a subscriber: CaseyCarter. ldionne added a comment. In D42225#2963190 , @mstorsjo wrote: > In D42225#2962348 , @ldionne wrote: > >> @pcc @mstorsjo Are we aware of anyone using these extensions? >> >> I

[PATCH] D42225: libcxx: Provide overloads for basic_filebuf::open() et al that take wchar_t* filenames on Windows.

2021-08-24 Thread Martin Storsjö via Phabricator via cfe-commits
mstorsjo added a comment. In D42225#2962348 , @ldionne wrote: > @pcc @mstorsjo Are we aware of anyone using these extensions? > > I would like to suggest that we either remove this extension if it's not > useful, or make it unconditional (not only on Wind

[PATCH] D42225: libcxx: Provide overloads for basic_filebuf::open() et al that take wchar_t* filenames on Windows.

2021-08-24 Thread Peter Collingbourne via Phabricator via cfe-commits
pcc added subscribers: thomasanderson, thakis. pcc added a comment. I believe that Chromium uses it (or at least it did at the time that I added this, and Chromium has since switched to using libc++ on Windows). I don't work on Chromium much anymore but perhaps @thakis or @thomasanderson can co

[PATCH] D42225: libcxx: Provide overloads for basic_filebuf::open() et al that take wchar_t* filenames on Windows.

2021-08-24 Thread Louis Dionne via Phabricator via cfe-commits
ldionne added subscribers: mstorsjo, ldionne. ldionne added a comment. Herald added a subscriber: libcxx-commits. @pcc @mstorsjo Are we aware of anyone using these extensions? I would like to suggest that we either remove this extension if it's not useful, or make it unconditional (not only on W

[PATCH] D42225: libcxx: Provide overloads for basic_filebuf::open() et al that take wchar_t* filenames on Windows.

2018-01-22 Thread Peter Collingbourne via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rCXX323170: libcxx: Provide overloads for basic_filebuf::open() et al that take wchar_t*… (authored by pcc, committed by ). Herald added a subscriber: cfe-commits. Changed prior to commit: https://review