[PATCH] D42266: [analyzer] Prevent AnalyzerStatsChecker from crash

2018-02-21 Thread Peter Szecsi via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC325693: [analyzer] Prevent AnalyzerStatsChecker from crash (authored by szepet, committed by ). Changed prior to commit: https://reviews.llvm.org/D42266?vs=130501&id=135266#toc Repository: rC Clang

[PATCH] D42266: [analyzer] Prevent AnalyzerStatsChecker from crash

2018-02-16 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ accepted this revision. NoQ added a subscriber: george.karpenkov. NoQ added a comment. This revision is now accepted and ready to land. Herald added a reviewer: george.karpenkov. LGTM! @george.karpenkov has also tested that when he was gathering statistics about his traversal order improvemen

[PATCH] D42266: [analyzer] Prevent AnalyzerStatsChecker from crash

2018-01-21 Thread Peter Szecsi via Phabricator via cfe-commits
szepet added a comment. > Would it make sense to use the last element of the block edge's source for > the diagnostic location when the destination block is empty? I do not think so. In the testfile `emptyConditionLoop` function is a great counter example since the last element of the source bl

[PATCH] D42266: [analyzer] Prevent AnalyzerStatsChecker from crash

2018-01-21 Thread Devin Coughlin via Phabricator via cfe-commits
dcoughlin added a comment. This seems reasonable. Would it make sense to use the last element of the block edge's source for the diagnostic location when the destination block is empty? Repository: rC Clang https://reviews.llvm.org/D42266 ___ c

[PATCH] D42266: [analyzer] Prevent AnalyzerStatsChecker from crash

2018-01-18 Thread Peter Szecsi via Phabricator via cfe-commits
szepet created this revision. szepet added reviewers: NoQ, dcoughlin, xazax.hun. Herald added subscribers: dkrupp, a.sidorin, rnkovacs, baloghadamsoftware, whisperity. The checker marks the locations where the analyzer creates sinks. However, it can happen that the sink was created because of a