dblaikie added a comment.
Just to clarify - the general philosophy (there are many cases of exceptions
due to complications in various areas) is that clang changes should have clang
tests (source code to IR), LLVM changes should have LLVM tests (IR to assembly
or object code+dwarf dump) & if
rnk requested changes to this revision.
rnk added a comment.
This revision now requires changes to proceed.
Still needs a test.
https://reviews.llvm.org/D42370
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
JDevlieghere accepted this revision as: JDevlieghere.
JDevlieghere added a comment.
This revision is now accepted and ready to land.
This makes sense to me, LGTM.
https://reviews.llvm.org/D42370
___
cfe-commits mailing list
probinson added subscribers: cfe-commits, probinson.
probinson added a comment.
+cfe-commits
See also the LLVM change in https://reviews.llvm.org/D42369 and a
debuginfo-tests test in https://reviews.llvm.org/D42371.
https://reviews.llvm.org/D42370
