This revision was automatically updated to reflect the committed changes.
Closed by commit rL323188: [clang-format] Ignore UnbreakableTailLength
sometimes during breaking (authored by krasimir, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
krasimir updated this revision to Diff 131023.
krasimir marked 3 inline comments as done.
krasimir added a comment.
- Update comment
Repository:
rC Clang
https://reviews.llvm.org/D42376
Files:
lib/Format/BreakableToken.cpp
lib/Format/BreakableToken.h
djasper accepted this revision.
djasper added a comment.
This revision is now accepted and ready to land.
Happy to go forward with this. I think we might also wanna investigate whether
entirely removing UnbreakableTailLength would be beneficial. I think we
implemented it as an optimization, but
krasimir added inline comments.
Comment at: lib/Format/ContinuationIndenter.cpp:1579
(Text.startswith(Prefix = "_T(\"") && Text.endswith(Postfix = "\")")))
{
+ unsigned UnbreakableTailLength = (State.NextToken && canBreak(State))
+
djasper added inline comments.
Comment at: lib/Format/ContinuationIndenter.cpp:1579
(Text.startswith(Prefix = "_T(\"") && Text.endswith(Postfix = "\")")))
{
+ unsigned UnbreakableTailLength = (State.NextToken && canBreak(State))
+
krasimir marked an inline comment as done.
krasimir added inline comments.
Comment at: lib/Format/ContinuationIndenter.cpp:1579
(Text.startswith(Prefix = "_T(\"") && Text.endswith(Postfix = "\")")))
{
+ unsigned UnbreakableTailLength = (State.NextToken &&
krasimir updated this revision to Diff 131012.
krasimir added a comment.
- Address review comments
Repository:
rC Clang
https://reviews.llvm.org/D42376
Files:
lib/Format/BreakableToken.cpp
lib/Format/BreakableToken.h
lib/Format/ContinuationIndenter.cpp
djasper added inline comments.
Comment at: lib/Format/ContinuationIndenter.cpp:1579
(Text.startswith(Prefix = "_T(\"") && Text.endswith(Postfix = "\")")))
{
+ unsigned UnbreakableTailLength = (State.NextToken && canBreak(State))
+
krasimir created this revision.
Herald added subscribers: cfe-commits, klimek.
Repository:
rC Clang
https://reviews.llvm.org/D42376
Files:
lib/Format/BreakableToken.cpp
lib/Format/BreakableToken.h
lib/Format/ContinuationIndenter.cpp
unittests/Format/FormatTestTextProto.cpp
Index:
