This revision was automatically updated to reflect the committed changes.
benhamilton marked an inline comment as done.
Closed by commit rC323668: [clang-format] Fix bug where -dump-config failed on
ObjC header (authored by benhamilton, committed by ).
Changed prior to commit:
https://reviews.l
krasimir accepted this revision.
krasimir added inline comments.
This revision is now accepted and ready to land.
Comment at: test/Format/lit.local.cfg:1
+# Suffixes supported by clang-format.
+config.suffixes = ['.c', '.cc', '.cpp', '.h', '.m', '.mm', '.java', '.js',
---
benhamilton requested review of this revision.
benhamilton marked 2 inline comments as done.
benhamilton added inline comments.
Comment at: test/Format/lit.local.cfg:1
+# Suffixes supported by clang-format.
+config.suffixes = ['.c', '.cc', '.cpp', '.h', '.m', '.mm', '.java', '.js
It's needed because otherwise lit ignores the .h file, which is the
configuration specified in the lit config in the parent directory.
On Fri, Jan 26, 2018, 01:55 Krasimir Georgiev via Phabricator <
revi...@reviews.llvm.org> wrote:
> krasimir requested changes to this revision.
> krasimir added i
krasimir requested changes to this revision.
krasimir added inline comments.
This revision now requires changes to proceed.
Comment at: test/Format/lit.local.cfg:1
+# Suffixes supported by clang-format.
+config.suffixes = ['.c', '.cc', '.cpp', '.h', '.m', '.mm', '.java', '.js',
-
benhamilton marked an inline comment as done.
benhamilton added inline comments.
Comment at: test/Format/lit.local.cfg:2-3
+# Suffixes supported by clang-format.
+config.suffixes = ['.cpp', '.h', '.m', '.mm', '.java', '.js', '.ts', '.proto',
+ '.protodevel', '.p
benhamilton updated this revision to Diff 131470.
benhamilton added a comment.
- Add more extensions.
Repository:
rC Clang
https://reviews.llvm.org/D42395
Files:
test/Format/dump-config-cxx.h
test/Format/dump-config-objc.h
test/Format/lit.local.cfg
tools/clang-format/ClangFormat.cpp
jolesiak requested changes to this revision.
jolesiak added inline comments.
This revision now requires changes to proceed.
Comment at: test/Format/lit.local.cfg:2-3
+# Suffixes supported by clang-format.
+config.suffixes = ['.cpp', '.h', '.m', '.mm', '.java', '.js', '.ts', '.pro
benhamilton updated this revision to Diff 130970.
benhamilton added a comment.
- Support AssumeFileName with stdin.
Repository:
rC Clang
https://reviews.llvm.org/D42395
Files:
test/Format/dump-config-cxx.h
test/Format/dump-config-objc.h
test/Format/lit.local.cfg
tools/clang-format/Cl
benhamilton created this revision.
benhamilton added reviewers: jolesiak, krasimir.
Herald added a subscriber: cfe-commits.
`clang-format -dump-config path/to/file.h` never passed
anything for the Code parameter to clang::format::getStyle().
This meant the logic to guess Objective-C from the cont
10 matches
Mail list logo
