This revision was automatically updated to reflect the committed changes.
Closed by commit rC325668: [Sema] Classify conversions from enum to float as
narrowing (authored by miyuki, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D42545
Files:
lib/Sema/SemaOverload.cpp
miyuki added a comment.
In https://reviews.llvm.org/D42545#1010335, @rogfer01 wrote:
> Do you plan to submit (in another change) the unscoped enum → integer type
> testcases? If this is not currently tested anywhere I think it may be a good
> thing to have them too.
Yes, I'll submit them in
rogfer01 accepted this revision.
rogfer01 added a comment.
This revision is now accepted and ready to land.
Looks good to me now. Wait a couple of days before submitting it just in case
the other reviewers have more comments.
Do you plan to submit (in another change) the unscoped enum → integer
miyuki added a comment.
ping
https://reviews.llvm.org/D42545
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
miyuki updated this revision to Diff 132974.
miyuki added a comment.
Removed the changes that are unrelated to the 'enum->float' case from the test.
https://reviews.llvm.org/D42545
Files:
lib/Sema/SemaOverload.cpp
test/CXX/dcl.decl/dcl.init/dcl.init.list/p7-0x.cpp
Index:
rogfer01 added a comment.
I understand you're fixing the narrowing check from "unscoped enum/integer
type" → float.
But you have also extended some tests which are "unscoped enum" → integer type
(lines 153, 170 and 173). So I presume they were already handled correctly
before your patch. Can
miyuki added a comment.
ping
https://reviews.llvm.org/D42545
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
miyuki created this revision.
miyuki added reviewers: faisalv, rsmith.
According to [dcl.init.list]p7:
A narrowing conversion is an implicit conversion
- ...
- from an integer type or unscoped enumeration type to a
floating-point type, except where the source is a constant
