sammccall updated this revision to Diff 132960.
sammccall marked an inline comment as done.
sammccall added a comment.
-test -> -lit-test
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D42919
Files:
clangd/ClangdLSPServer.cpp
clangd/ClangdLSPServer.h
sammccall marked an inline comment as done.
sammccall added a comment.
In https://reviews.llvm.org/D42919#998695, @ioeric wrote:
> LGTM
>
> Have we kept a lit test that uses content-length? It's unclear from the patch.
Yes, `protocol.test` tests the real protocol parser. (The other tests that
ioeric accepted this revision.
ioeric added a comment.
This revision is now accepted and ready to land.
LGTM
Have we kept a lit test that uses content-length? It's unclear from the patch.
Comment at: clangd/tool/ClangdMain.cpp:89
+static llvm::cl::opt Test(
+"test",
+
sammccall created this revision.
sammccall added a reviewer: ioeric.
Herald added subscribers: cfe-commits, jkorous-apple, ilya-biryukov, klimek.
Instead of content-length, we delimit messages with ---.
This also removes the need for (most) dos-formatted test files.
Repository:
rCTE Clang
