[PATCH] D42947: Support special acronyms inside property names and allow plural forms

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE324407: Support special acronyms inside property names and allow plural forms (authored by Wizard, committed by ). Changed prior to commit: https://reviews.llvm.org/D42947?vs=133069=133071#toc

[PATCH] D42947: Support special acronyms inside property names and allow plural forms

Wizard updated this revision to Diff 133069. Wizard added a comment. minor fix according to comments Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42947 Files: clang-tidy/objc/PropertyDeclarationCheck.cpp test/clang-tidy/objc-property-declaration.m Index:

[PATCH] D42947: Support special acronyms inside property names and allow plural forms

benhamilton accepted this revision. benhamilton added inline comments. This revision is now accepted and ready to land. Comment at: clang-tidy/objc/PropertyDeclarationCheck.cpp:144 + "[A-Z]?)?[a-z]+[a-z0-9]*(" + + AcronymsGroupRegex(EscapedAcronyms, true) +

[PATCH] D42947: Support special acronyms inside property names and allow plural forms

Wizard updated this revision to Diff 133066. Wizard added a comment. resolve comments Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42947 Files: clang-tidy/objc/PropertyDeclarationCheck.cpp test/clang-tidy/objc-property-declaration.m Index:

[PATCH] D42947: Support special acronyms inside property names and allow plural forms

Wizard added inline comments. Comment at: clang-tidy/objc/PropertyDeclarationCheck.cpp:142 - return StartMatcher + "((" + - llvm::join(EscapedAcronyms.begin(), EscapedAcronyms.end(), "|") + - ")[A-Z]?)?[a-z]+[a-z0-9]*([A-Z][a-z0-9]+)*" + "(" + -

[PATCH] D42947: Support special acronyms inside property names and allow plural forms

benhamilton requested changes to this revision. benhamilton added a comment. This revision now requires changes to proceed. Can you add test cases for non-plural acronyms in the middle of the string and plural acronyms at the start/end of the string, please? Comment at:

[PATCH] D42947: Support special acronyms inside property names and allow plural forms

hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. LGTM Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42947 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D42947: Support special acronyms inside property names and allow plural forms

Wizard updated this revision to Diff 132938. Wizard added a comment. resolve conflict in doc Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42947 Files: clang-tidy/objc/PropertyDeclarationCheck.cpp test/clang-tidy/objc-property-declaration.m Index:

[PATCH] D42947: Support special acronyms inside property names and allow plural forms

Wizard created this revision. Herald added subscribers: cfe-commits, klimek. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D42947 Files: clang-tidy/objc/PropertyDeclarationCheck.cpp docs/clang-tidy/checks/objc-property-declaration.rst