This revision was automatically updated to reflect the committed changes.
Closed by commit rC324884: ASan+operator new[]: Add an option for more thorough
operator new[] cookie… (authored by filcab, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D43013?vs=133389=133830#toc
rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.
Okay, thanks. LGTM.
Repository:
rC Clang
https://reviews.llvm.org/D43013
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
filcab updated this revision to Diff 133389.
filcab added a comment.
Update commit message.
Repository:
rC Clang
https://reviews.llvm.org/D43013
Files:
include/clang/Driver/Options.td
include/clang/Frontend/CodeGenOptions.def
lib/CodeGen/ItaniumCXXABI.cpp
filcab added a comment.
In https://reviews.llvm.org/D43013#1001006, @rjmccall wrote:
> I don't understand why your description of this patch mentions the void*
> placement new[] operator. There's no cookie to poison for that operator.
Hah, sorry. In writing this commit log I used parts of
rjmccall added a comment.
I don't understand why your description of this patch mentions the void*
placement new[] operator. There's no cookie to poison for that operator.
Repository:
rC Clang
https://reviews.llvm.org/D43013
___
cfe-commits
filcab created this revision.
filcab added reviewers: rjmccall, kcc, rsmith.
The C++ Itanium ABI says:
No cookie is required if the new operator being used is ::operator
new[](size_t, void*).
This commit adds a flag to tell clang to poison all operator new[]
cookies.
A previous review was
