[PATCH] D43121: clang-format: keep ObjC colon alignment with short object name

This revision was automatically updated to reflect the committed changes. Closed by commit rC324741: clang-format: keep ObjC colon alignment with short object name (authored by Typz, committed by ). Changed prior to commit: https://reviews.llvm.org/D43121?vs=133619=133620#toc Repository: rC

[PATCH] D43121: clang-format: keep ObjC colon alignment with short object name

Typz updated this revision to Diff 133619. Typz added a comment. rebase on latest master. Repository: rC Clang https://reviews.llvm.org/D43121 Files: lib/Format/ContinuationIndenter.cpp lib/Format/TokenAnnotator.cpp unittests/Format/FormatTestObjC.cpp Index:

[PATCH] D43121: clang-format: keep ObjC colon alignment with short object name

djasper accepted this revision. djasper added a comment. This revision is now accepted and ready to land. Looks good. Repository: rC Clang https://reviews.llvm.org/D43121 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D43121: clang-format: keep ObjC colon alignment with short object name

Typz added inline comments. Comment at: lib/Format/ContinuationIndenter.cpp:900 + std::max(NextNonComment->LongestObjCSelectorName, + unsigned(NextNonComment->TokenText.size())) - NextNonComment->ColumnWidth;

[PATCH] D43121: clang-format: keep ObjC colon alignment with short object name

Typz updated this revision to Diff 133596. Typz marked 2 inline comments as done. Typz added a comment. Address review comments Repository: rC Clang https://reviews.llvm.org/D43121 Files: lib/Format/ContinuationIndenter.cpp lib/Format/TokenAnnotator.cpp

[PATCH] D43121: clang-format: keep ObjC colon alignment with short object name

krasimir added inline comments. Comment at: unittests/Format/FormatTestObjC.cpp:700 + "withObjectOnMainThread:nil\n" + " waitUntilDone:false];"); + } Could you add an instance where the first one is the

[PATCH] D43121: clang-format: keep ObjC colon alignment with short object name

djasper added inline comments. Comment at: lib/Format/ContinuationIndenter.cpp:900 + std::max(NextNonComment->LongestObjCSelectorName, + unsigned(NextNonComment->TokenText.size())) - NextNonComment->ColumnWidth; I'd

[PATCH] D43121: clang-format: keep ObjC colon alignment with short object name

Typz updated this revision to Diff 133589. Typz added a comment. fix type in commit message Repository: rC Clang https://reviews.llvm.org/D43121 Files: lib/Format/ContinuationIndenter.cpp lib/Format/TokenAnnotator.cpp unittests/Format/FormatTestObjC.cpp Index:

[PATCH] D43121: clang-format: keep ObjC colon alignment with short object name

Typz created this revision. Typz added reviewers: krasimir, djasper, klimek. When the target object expression is short and the first selector name is long, clang-format used to break the colon alignment: [I performSelectorOnMainThread:@selector(loadAccessories)