Re: [PATCH] D43128: Introduce an API for LLDB to compute the default module cache path

2018-02-12 Thread Adrian Prantl via cfe-commits
> On Feb 12, 2018, at 8:32 AM, David Blaikie wrote: > > Unit test? Added in r324917. -- adrian ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D43128: Introduce an API for LLDB to compute the default module cache path

2018-02-12 Thread David Blaikie via cfe-commits
Unit test? On Fri, Feb 9, 2018 at 10:45 AM Phabricator via Phabricator via llvm-commits wrote: > This revision was automatically updated to reflect the committed changes. > Closed by commit rL324761: Introduce an API for LLDB to compute the > default module cache path (authored by adrian, commit

[PATCH] D43128: Introduce an API for LLDB to compute the default module cache path

2018-02-09 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL324761: Introduce an API for LLDB to compute the default module cache path (authored by adrian, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org

[PATCH] D43128: Introduce an API for LLDB to compute the default module cache path

2018-02-09 Thread Bruno Cardoso Lopes via Phabricator via cfe-commits
bruno accepted this revision. bruno added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D43128 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com

[PATCH] D43128: Introduce an API for LLDB to compute the default module cache path

2018-02-09 Thread Adrian Prantl via Phabricator via cfe-commits
aprantl created this revision. aprantl added reviewers: bruno, jingham. LLDB creates Clang modules and had an incomplete copy of the clang Driver code that compute the -fmodule-cache-path. This patch makes the clang driver code accessible to LLDB. https://reviews.llvm.org/D43128 Files: incl