[PATCH] D43227: [clangd] Make functions of ClangdServer callback-based

CarlosAlbertoEnciso added a comment. Build now is OK. Thanks @ilya-biryukov Repository: rL LLVM https://reviews.llvm.org/D43227 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D43227: [clangd] Make functions of ClangdServer callback-based

Sorry about that, fixed in r325254. I keep hitting this MSVC compilation error all the time. On Thu, Feb 15, 2018 at 4:26 PM Carlos Alberto Enciso via Phabricator < revi...@reviews.llvm.org> wrote: > CarlosAlbertoEnciso added a comment. > > Hi, > > It seems that your submission broke the

[PATCH] D43227: [clangd] Make functions of ClangdServer callback-based

CarlosAlbertoEnciso added a comment. Hi, It seems that your submission broke the Windows/Linux builds for 'clangd'. The generated error message is: C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\include\future(263): error C2512:

[PATCH] D43227: [clangd] Make functions of ClangdServer callback-based

This revision was automatically updated to reflect the committed changes. Closed by commit rL325233: [clangd] Make functions of ClangdServer callback-based (authored by ibiryukov, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D43227

[PATCH] D43227: [clangd] Make functions of ClangdServer callback-based

ilya-biryukov updated this revision to Diff 134406. ilya-biryukov added a comment. - Rebase onto head Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D43227 Files: clangd/ClangdLSPServer.cpp clangd/ClangdServer.cpp clangd/ClangdServer.h unittests/clangd/ClangdTests.cpp

[PATCH] D43227: [clangd] Make functions of ClangdServer callback-based

ioeric accepted this revision. ioeric added a comment. lg Comment at: clangd/ClangdServer.cpp:209 + auto Action = [Contents, Pos, TaggedFS, + PCHs](Path File, decltype(Callback) Callback, + llvm::Expected IP) {

[PATCH] D43227: [clangd] Make functions of ClangdServer callback-based

ilya-biryukov updated this revision to Diff 134169. ilya-biryukov marked 4 inline comments as done. ilya-biryukov added a comment. - Use llvm::Optional<> in capture() helper to avoid confusion with llvm::Expected. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D43227 Files:

[PATCH] D43227: [clangd] Make functions of ClangdServer callback-based

ilya-biryukov added a comment. In https://reviews.llvm.org/D43227#1006584, @sammccall wrote: > I wonder whether we want to introduce `using Callback = > UniqueFunction` for readability at some point... I agree that's a good idea, will come up with a CL doing that.

[PATCH] D43227: [clangd] Make functions of ClangdServer callback-based

sammccall accepted this revision. sammccall added a comment. This revision is now accepted and ready to land. LG, suggest a tweak to capture() though. I wonder whether we want to introduce `using Callback = UniqueFunction` for readability at some point... Comment

[PATCH] D43227: [clangd] Make functions of ClangdServer callback-based

ioeric added inline comments. Comment at: clangd/ClangdLSPServer.cpp:194 +if (!Replacements) + return replyError(ErrorCode::InternalError, +llvm::toString(Replacements.takeError())); ilya-biryukov wrote: > ioeric

[PATCH] D43227: [clangd] Make functions of ClangdServer callback-based

ilya-biryukov updated this revision to Diff 134080. ilya-biryukov added a comment. - Capture only needed vars in lambda, not everything. - Rebase onto head. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D43227 Files: clangd/ClangdLSPServer.cpp clangd/ClangdServer.cpp

[PATCH] D43227: [clangd] Make functions of ClangdServer callback-based

ilya-biryukov added inline comments. Comment at: clangd/ClangdLSPServer.cpp:194 +if (!Replacements) + return replyError(ErrorCode::InternalError, +llvm::toString(Replacements.takeError())); ioeric wrote: > nit: since

[PATCH] D43227: [clangd] Make functions of ClangdServer callback-based

ioeric added inline comments. Comment at: clangd/ClangdLSPServer.cpp:194 +if (!Replacements) + return replyError(ErrorCode::InternalError, +llvm::toString(Replacements.takeError())); nit: since we are not spelling out

[PATCH] D43227: [clangd] Make functions of ClangdServer callback-based

ilya-biryukov created this revision. ilya-biryukov added reviewers: sammccall, ioeric, hokein. Herald added subscribers: jkorous-apple, klimek. As a consequence, all LSP operations are now handled asynchronously, i.e. they never block the main processing thread. However, if -run-synchronously