CarlosAlbertoEnciso added a comment.
In https://reviews.llvm.org/D43272#1008703, @sammccall wrote:
> r325239 should fix, sorry!
Build now is OK. Thanks @sammccall.
Repository:
rL LLVM
https://reviews.llvm.org/D43272
___
cfe-commits mailing lis
sammccall added a comment.
r325239 should fix, sorry!
Repository:
rL LLVM
https://reviews.llvm.org/D43272
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
CarlosAlbertoEnciso added a comment.
Hi,
It seems that your submission have broken the Windows and Linux Builds for
'clangd'.
This is the error message:
/home/xxx/llvm-root/llvm/tools/clang/tools/extra/clangd/Trace.cpp:54:76: error:
call of overloaded ‘make_unique(clang::clangd::trace::{anony
This revision was automatically updated to reflect the committed changes.
Closed by commit rL325220: [clangd] Fix tracing now that spans lifetimes can
overlap on a thread. (authored by sammccall, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.
sammccall added inline comments.
Comment at: clangd/Trace.cpp:133
+std::atomic EndTime; // Filled in by endSpan().
+std::string Name;
+const uint64_t TID;
ilya-biryukov wrote:
> Maybe make all fields except `EndTime` const?
Good idea - what's safe to
sammccall updated this revision to Diff 134386.
sammccall added a comment.
address review comments
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D43272
Files:
clangd/Trace.cpp
clangd/Trace.h
test/clangd/trace.test
unittests/clangd/TraceTests.cpp
Index: unittests/clangd
ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.
LG with a few NITs.
Comment at: clangd/Trace.cpp:133
+std::atomic EndTime; // Filled in by endSpan().
+std::string Name;
+const uint64_t TID;
--
sammccall created this revision.
sammccall added a reviewer: ioeric.
Herald added subscribers: cfe-commits, jkorous-apple, ilya-biryukov, klimek.
The chrome trace viewer requires events within a thread to strictly nest.
So we need to record the lifetime of the Span objects, not the contexts.
But
