[PATCH] D43341: [clang-doc] Implement reducer portion of the frontend framework

This revision was automatically updated to reflect the committed changes. Closed by commit rL333932: [clang-doc] Implement reducer portion of the frontend framework (authored by juliehockett, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.

[PATCH] D43341: [clang-doc] Implement reducer portion of the frontend framework

juliehockett updated this revision to Diff 149500. juliehockett marked 8 inline comments as done. https://reviews.llvm.org/D43341 Files: clang-doc/BitcodeReader.cpp clang-doc/BitcodeReader.h clang-doc/BitcodeWriter.cpp clang-doc/BitcodeWriter.h clang-doc/CMakeLists.txt clang-doc/Repre

[PATCH] D43341: [clang-doc] Implement reducer portion of the frontend framework

ioeric accepted this revision. ioeric added a comment. This revision is now accepted and ready to land. lgtm with just a few more nits. Comment at: clang-doc/BitcodeWriter.cpp:484 #undef EMITINFO Nit: `EMITINFO` is a bit confusing with `writeInfo`. Are the

[PATCH] D43341: [clang-doc] Implement reducer portion of the frontend framework

juliehockett added inline comments. Comment at: clang-doc/tool/ClangDocMain.cpp:181 +doc::writeInfo(I.get(), Buffer); + if (DumpResultToFile("bc", Group.getKey() + ".bc", Buffer)) +return 1; ioeric wrote: > juliehockett wrote: > > ioeric wrot

[PATCH] D43341: [clang-doc] Implement reducer portion of the frontend framework

juliehockett updated this revision to Diff 149371. juliehockett marked 13 inline comments as done. juliehockett added a comment. Fixing comments https://reviews.llvm.org/D43341 Files: clang-doc/BitcodeReader.cpp clang-doc/BitcodeReader.h clang-doc/BitcodeWriter.cpp clang-doc/BitcodeWrit

[PATCH] D43341: [clang-doc] Implement reducer portion of the frontend framework

ioeric added inline comments. Comment at: clang-doc/BitcodeReader.cpp:553 + +#define READINFO(INFO) \ + { \ Convert this to a tem

[PATCH] D43341: [clang-doc] Implement reducer portion of the frontend framework

juliehockett added inline comments. Comment at: clang-doc/Representation.h:138 + SymbolID USR = + SymbolID(); // Unique identifier for the decl described by this Info. + const InfoType IT = InfoType::IT_default; // InfoType of this particular Info. ioeric

[PATCH] D43341: [clang-doc] Implement reducer portion of the frontend framework

juliehockett updated this revision to Diff 148678. juliehockett marked 11 inline comments as done. juliehockett added a comment. Reworking the reducer interface a bit to address comments. https://reviews.llvm.org/D43341 Files: clang-doc/BitcodeReader.cpp clang-doc/BitcodeReader.h clang-do

[PATCH] D43341: [clang-doc] Implement reducer portion of the frontend framework

ioeric added a comment. The reduce logic seems to be in a good shape. Some nits and questions inlined. Comment at: clang-doc/Reducer.cpp:19 + +#define REDUCE(INFO) \ + {

[PATCH] D43341: [clang-doc] Implement reducer portion of the frontend framework

juliehockett added a comment. ping https://reviews.llvm.org/D43341 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D43341: [clang-doc] Implement reducer portion of the frontend framework

juliehockett added a comment. Pingany more thoughts? https://reviews.llvm.org/D43341 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D43341: [clang-doc] Implement reducer portion of the frontend framework

juliehockett added a comment. In https://reviews.llvm.org/D43341#1093117, @juliehockett wrote: > This will break things in clang-tools-extra without > https://reviews.llvm.org/D46615, so I'm going to hold off landing this until > that goes through Oops wrong patch disregard https://reviews.

[PATCH] D43341: [clang-doc] Implement reducer portion of the frontend framework

juliehockett added a comment. This will break things in clang-tools-extra without https://reviews.llvm.org/D46615, so I'm going to hold off landing this until that goes through https://reviews.llvm.org/D43341 ___ cfe-commits mailing list cfe-commi

[PATCH] D43341: [clang-doc] Implement reducer portion of the frontend framework

juliehockett added inline comments. Comment at: clang-doc/Representation.cpp:53 + move(Namespace, std::move(Other.Namespace)); + extend(Description, std::move(Other.Description)); + return true; sammccall wrote: > is plain concatenation of comments what you wa

[PATCH] D43341: [clang-doc] Implement reducer portion of the frontend framework

juliehockett updated this revision to Diff 144948. juliehockett marked 17 inline comments as done. juliehockett added a comment. Cleaning up and clarifying the merging process, and addressing comments https://reviews.llvm.org/D43341 Files: clang-doc/BitcodeReader.cpp clang-doc/BitcodeReader

[PATCH] D43341: [clang-doc] Implement reducer portion of the frontend framework

sammccall added inline comments. Comment at: clang-doc/Index.h:28 +// Abstract class representing an index of mapped info objects. +class Index { +public: What is this interface for? It looks like none of the functions are ever called through the interface. If

[PATCH] D43341: [clang-doc] Implement reducer portion of the frontend framework

lebedev.ri added inline comments. Comment at: clang-doc/BitcodeWriter.h:129 // Check that the static size is large-enough. assert(Record.capacity() > BitCodeConstants::RecordSize); } juliehockett wrote: > lebedev.ri wrote: > > lebedev.ri wrote: > > >

[PATCH] D43341: [clang-doc] Implement reducer portion of the frontend framework

juliehockett marked 5 inline comments as done. juliehockett added inline comments. Comment at: clang-doc/BitcodeReader.h:59 + + void storeData(llvm::SmallVectorImpl &Field, llvm::StringRef Blob); + void storeData(bool &Field, llvm::StringRef Blob); sammccall wr

[PATCH] D43341: [clang-doc] Implement reducer portion of the frontend framework

juliehockett updated this revision to Diff 144011. juliehockett marked 17 inline comments as done. juliehockett added a comment. Reorganizing and streamlining, particularly in decoupling the reader from the reduce process and redesigning a bit to allow for more flexible reducing. Currently imple

[PATCH] D43341: [clang-doc] Implement reducer portion of the frontend framework

sammccall added a comment. OK, I didn't get through all the detail, but we should talk about the MR stuff today :) Comment at: clang-doc/BitcodeReader.cpp:25 +void ClangDocBitcodeReader::storeData(SymbolID &Field, llvm::StringRef Blob) { + assert(Record[0] == 20); + // First

[PATCH] D43341: [clang-doc] Implement reducer portion of the frontend framework

juliehockett updated this revision to Diff 140275. juliehockett added a comment. Fixing assert on vector size. https://reviews.llvm.org/D43341 Files: clang-doc/BitcodeReader.cpp clang-doc/BitcodeReader.h clang-doc/BitcodeWriter.cpp clang-doc/BitcodeWriter.h clang-doc/CMakeLists.txt

[PATCH] D43341: [clang-doc] Implement reducer portion of the frontend framework

lebedev.ri added inline comments. Comment at: clang-doc/BitcodeWriter.h:129 // Check that the static size is large-enough. assert(Record.capacity() > BitCodeConstants::RecordSize); } lebedev.ri wrote: > juliehockett wrote: > > lebedev.ri wrote: > > >

[PATCH] D43341: [clang-doc] Implement reducer portion of the frontend framework

lebedev.ri added inline comments. Comment at: clang-doc/BitcodeWriter.h:129 // Check that the static size is large-enough. assert(Record.capacity() > BitCodeConstants::RecordSize); } juliehockett wrote: > lebedev.ri wrote: > > Isn't that the opposite

[PATCH] D43341: [clang-doc] Implement reducer portion of the frontend framework

juliehockett added inline comments. Comment at: clang-doc/BitcodeReader.cpp:27 + assert(Record[0] == 20); + for (int I = 0, E = Record[0]; I < E; ++I) +Field[I] = Record[I + 1]; lebedev.ri wrote: > Ok, i don't understand what is going on here. > Where is th

[PATCH] D43341: [clang-doc] Implement reducer portion of the frontend framework

juliehockett updated this revision to Diff 139972. juliehockett marked 4 inline comments as done. juliehockett added a comment. Small fixes to address comments https://reviews.llvm.org/D43341 Files: clang-doc/BitcodeReader.cpp clang-doc/BitcodeReader.h clang-doc/BitcodeWriter.cpp clang-

[PATCH] D43341: [clang-doc] Implement reducer portion of the frontend framework

lebedev.ri added a comment. It's surprisingly difficult to review this :/ Just by itself the logic is simple, but the amount of blocks/records/record types is kinda demoralizing. I really hope it will be possible to somehow tablegen this later. Comment at: clang-doc/BitcodeRea

[PATCH] D43341: [clang-doc] Implement reducer portion of the frontend framework

Eugene.Zelenko added a comment. Please mention new tool in Release Notes and use //:doc:// to refer to its manual. https://reviews.llvm.org/D43341 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinf

[PATCH] D43341: [clang-doc] Implement reducer portion of the frontend framework

juliehockett updated this revision to Diff 139869. juliehockett marked 13 inline comments as done. juliehockett added a comment. Addressing comments https://reviews.llvm.org/D43341 Files: clang-doc/BitcodeReader.cpp clang-doc/BitcodeReader.h clang-doc/BitcodeWriter.cpp clang-doc/Bitcode

[PATCH] D43341: [clang-doc] Implement reducer portion of the frontend framework

lebedev.ri added a comment. It's good to finally have the initial block firmly landed, congratulations. Trying to review this... Some initial thoughts. Comment at: clang-doc/BitcodeReader.cpp:27 + assert(Record[0] == 20); + for (int I = 0, E = Record[0]; I < E; ++I) +Fie

[PATCH] D43341: [clang-doc] Implement reducer portion of the frontend framework

juliehockett updated this revision to Diff 139644. juliehockett added a comment. Rebasing and updating. https://reviews.llvm.org/D43341 Files: clang-doc/BitcodeReader.cpp clang-doc/BitcodeReader.h clang-doc/BitcodeWriter.cpp clang-doc/BitcodeWriter.h clang-doc/CMakeLists.txt clang-d

[PATCH] D43341: [clang-doc] Implement reducer portion of the frontend framework

lebedev.ri added a comment. Once the base differential firmly lands, could you please rebase this so the review could continue? https://reviews.llvm.org/D43341 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/ma

[PATCH] D43341: [clang-doc] Implement reducer portion of the frontend framework

juliehockett added inline comments. Comment at: clang-doc/BitcodeReader.cpp:19 + +void ClangDocBitcodeReader::storeData(llvm::SmallString<4> &Field, + llvm::StringRef Blob) { lebedev.ri wrote: > I think all these `SmallString`

[PATCH] D43341: [clang-doc] Implement reducer portion of the frontend framework

juliehockett updated this revision to Diff 137245. juliehockett marked 8 inline comments as done. juliehockett added a comment. Adding in support for mapper tests and addressing comments. https://reviews.llvm.org/D43341 Files: clang-doc/BitcodeReader.cpp clang-doc/BitcodeReader.h clang-do

[PATCH] D43341: [clang-doc] Implement reducer portion of the frontend framework

lebedev.ri added a comment. Thank you for working on this! Finally trying to review this... I must say i'm **really** not fond of the test 'changes'. But some initial comments added: Comment at: clang-doc/BitcodeReader.cpp:19 + +void ClangDocBitcodeReader::storeData(llvm::Sma

[PATCH] D43341: [clang-doc] Implement reducer portion of the frontend framework

juliehockett updated this revision to Diff 136793. juliehockett added a comment. Updating for parent diff & refactoring reader. https://reviews.llvm.org/D43341 Files: clang-doc/BitcodeReader.cpp clang-doc/BitcodeReader.h clang-doc/BitcodeWriter.cpp clang-doc/BitcodeWriter.h clang-doc/

[PATCH] D43341: [clang-doc] Implement reducer portion of the frontend framework

juliehockett updated this revision to Diff 136660. juliehockett marked an inline comment as done. juliehockett added a comment. Cleaning up some and updating based on changes to the parent diff. https://reviews.llvm.org/D43341 Files: clang-doc/BitcodeReader.cpp clang-doc/BitcodeReader.h c

[PATCH] D43341: [clang-doc] Implement reducer portion of the frontend framework

Eugene.Zelenko added a comment. Please run Clang-format and Clang-tidy modernize. Comment at: clang-doc/BitcodeReader.h:36 + public: + ClangDocBitcodeReader() {} + using RecordData = SmallVector; Please use = default; https://reviews.llvm.org/D43341

[PATCH] D43341: [clang-doc] Implement reducer portion of the frontend framework

juliehockett updated this revision to Diff 135520. juliehockett added a comment. Updating for parent diff changes https://reviews.llvm.org/D43341 Files: clang-doc/BitcodeReader.cpp clang-doc/BitcodeReader.h clang-doc/BitcodeWriter.cpp clang-doc/BitcodeWriter.h clang-doc/CMakeLists.txt

[PATCH] D43341: [clang-doc] Implement reducer portion of the frontend framework

juliehockett updated this revision to Diff 134546. juliehockett edited the summary of this revision. juliehockett added a comment. Moving the entire implementation of the bitcode reader to this patch (from the mapper patch, here ) and cleaning up implementation

[PATCH] D43341: [clang-doc] Implement reducer portion of the frontend framework

juliehockett created this revision. juliehockett added reviewers: klimek, sammccall, jakehehrlich. juliehockett added a project: clang-tools-extra. Herald added a subscriber: mgorny. juliehockett added a dependency: D41102: Setup clang-doc frontend framework. Implements a simple, in-memory reducer