krytarowski added inline comments.
Comment at: cfe/trunk/test/Driver/XRay/xray-instrument-os.c:2
// RUN: not %clang -o /dev/null -v -fxray-instrument -c %s
-// XFAIL: -linux-
// REQUIRES-ANY: amd64, x86_64, x86_64h, arm, aarch64, arm64
```
krytarowski added inline comments.
Comment at: cfe/trunk/test/Driver/XRay/xray-shared-noxray.cpp:11
//
-// REQUIRES: linux, enable_shared
+// REQUIRES: enable_shared
int foo() { return 42; }
```
FAIL: Clang :: Driver/XRay/xray-shared-noxray.cpp (6820 of 38122)
This revision was automatically updated to reflect the committed changes.
Closed by commit rL325746: FreeBSD driver / Xray flags moving pthread to
compile flags. (authored by kamil, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
emaste accepted this revision.
emaste added a comment.
In https://reviews.llvm.org/D43378#1010574, @devnexen wrote:
> As I see only x86_64 arch implements everything (e.g. custom event), making
> things easier maybe. arm family might be enabled, power pc might need to
> rewrite as x86_64 arch
devnexen added a comment.
In https://reviews.llvm.org/D43378#1010464, @emaste wrote:
> LGTM with one small note.
>
> What will it take for us to enable this on the rest of the platforms
> Clang/FreeBSD supports?
As I see only x86_64 arch implements everything (e.g. custom event), making
devnexen updated this revision to Diff 134659.
https://reviews.llvm.org/D43378
Files:
lib/Driver/ToolChains/FreeBSD.cpp
lib/Driver/XRayArgs.cpp
test/Driver/XRay/lit.local.cfg
test/Driver/XRay/xray-instrument-os.c
test/Driver/XRay/xray-shared-noxray.cpp
Index: lib/Driver/XRayArgs.cpp
emaste added a comment.
LGTM with one small note.
What will it take for us to enable this on the rest of the platforms
Clang/FreeBSD supports?
Comment at: test/Driver/XRay/lit.local.cfg:7-8
supported_targets = [
'x86_64', 'x86_64h', 'arm', 'aarch64', 'arm64',
krytarowski added inline comments.
Comment at: lib/Driver/XRayArgs.cpp:54
+if (Triple.getArch() != llvm::Triple::x86_64) {
+ D.Diag(diag::err_drv_clang_unsupported)
+ << (std::string(XRayInstrumentOption) + " on " + Triple.str());
devnexen added inline comments.
Comment at: lib/Driver/XRayArgs.cpp:54
+if (Triple.getArch() != llvm::Triple::x86_64) {
+ D.Diag(diag::err_drv_clang_unsupported)
+ << (std::string(XRayInstrumentOption) + " on " + Triple.str());
krytarowski added inline comments.
Comment at: lib/Driver/XRayArgs.cpp:54
+if (Triple.getArch() != llvm::Triple::x86_64) {
+ D.Diag(diag::err_drv_clang_unsupported)
+ << (std::string(XRayInstrumentOption) + " on " + Triple.str());
devnexen updated this revision to Diff 134634.
https://reviews.llvm.org/D43378
Files:
lib/Driver/ToolChains/FreeBSD.cpp
lib/Driver/XRayArgs.cpp
test/Driver/XRay/lit.local.cfg
test/Driver/XRay/xray-instrument-os.c
test/Driver/XRay/xray-shared-noxray.cpp
Index:
devnexen updated this revision to Diff 134628.
devnexen added a comment.
Herald added a subscriber: srhines.
Enabling one test for FreeBSD
https://reviews.llvm.org/D43378
Files:
lib/Driver/ToolChains/FreeBSD.cpp
lib/Driver/XRayArgs.cpp
test/Driver/XRay/lit.local.cfg
krytarowski added a comment.
Please add a clang test to verify that we can pass xray flags, as requested by
@dberris.
https://reviews.llvm.org/D43378
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
devnexen updated this revision to Diff 134622.
devnexen added a comment.
Reusing generic message/reformating.
https://reviews.llvm.org/D43378
Files:
lib/Driver/ToolChains/FreeBSD.cpp
lib/Driver/XRayArgs.cpp
Index: lib/Driver/XRayArgs.cpp
devnexen added inline comments.
Comment at: lib/Driver/XRayArgs.cpp:56
+<< (std::string(XRayInstrumentOption) + " only on "
+"FreeBSD x86_64");
+}
krytarowski wrote:
> krytarowski wrote:
> > I think it's better to not
krytarowski added inline comments.
Comment at: lib/Driver/XRayArgs.cpp:56
+<< (std::string(XRayInstrumentOption) + " only on "
+"FreeBSD x86_64");
+}
krytarowski wrote:
> I think it's better to not hardcode `x86_64`
devnexen updated this revision to Diff 134605.
devnexen added a comment.
Updating the warning messages.
https://reviews.llvm.org/D43378
Files:
lib/Driver/ToolChains/FreeBSD.cpp
lib/Driver/XRayArgs.cpp
Index: lib/Driver/XRayArgs.cpp
emaste added a comment.
Please upload reviews with context (e.g. `git diff -U9`, `git show
-U9`, or `svn diff -x -U99`).
See https://llvm.org/docs/Phabricator.html for more info.
Comment at: lib/Driver/XRayArgs.cpp:60
D.Diag(diag::err_drv_clang_unsupported)
krytarowski added inline comments.
Comment at: lib/Driver/XRayArgs.cpp:56
+<< (std::string(XRayInstrumentOption) + " only on "
+"FreeBSD x86_64");
+}
I think it's better to not hardcode `x86_64` here in a message, we
krytarowski added a comment.
I was wrong about `-pthread` here, as we pass it directly to a linker. ld(1)
accepts `-lpthread` not `-pthread`. cc(1) requires `-pthread` as it defines
additional flags like `_REENTRANT` (OS-specific).
https://reviews.llvm.org/D43378
dberris added a comment.
Looks OK, but can we have a test for this somehow?
https://reviews.llvm.org/D43378
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
devnexen updated this revision to Diff 134586.
devnexen edited the summary of this revision.
https://reviews.llvm.org/D43378
Files:
lib/Driver/ToolChains/FreeBSD.cpp
lib/Driver/XRayArgs.cpp
Index: lib/Driver/XRayArgs.cpp
===
devnexen created this revision.
devnexen added reviewers: krytarowski, vitalybuka, dberris.
devnexen created this object with visibility "All Users".
Herald added subscribers: cfe-commits, emaste.
devnexen edited the summary of this revision.
-pthread was into linkage step.
-Warning about the
23 matches
Mail list logo
