This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE325523: [clangd] Fixes for #include insertion. (authored
by ioeric, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D43462?vs=134947=134952#toc
Repository:
rL LLVM
This revision was automatically updated to reflect the committed changes.
Closed by commit rL325523: [clangd] Fixes for #include insertion. (authored by
ioeric, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D43462
Files:
ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D43462
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
ioeric updated this revision to Diff 134947.
ioeric added a comment.
- assert in the very beginning!
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D43462
Files:
clangd/ClangdServer.cpp
clangd/Headers.cpp
clangd/Headers.h
clangd/index/CanonicalIncludes.cpp
ioeric updated this revision to Diff 134944.
ioeric marked 2 inline comments as done.
ioeric added a comment.
- added a comment about thread safety
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D43462
Files:
clangd/ClangdServer.cpp
clangd/Headers.cpp
clangd/Headers.h
ioeric marked 5 inline comments as done.
ioeric added inline comments.
Comment at: clangd/Headers.cpp:60
Argv.push_back(S.c_str());
IgnoringDiagConsumer IgnoreDiags;
auto CI = clang::createInvocationFromCommandLine(
ilya-biryukov wrote:
> Not related
ioeric updated this revision to Diff 134943.
ioeric marked 3 inline comments as done.
ioeric added a comment.
- addressed comments.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D43462
Files:
clangd/ClangdServer.cpp
clangd/Headers.cpp
clangd/Headers.h
ilya-biryukov added inline comments.
Comment at: clangd/index/CanonicalIncludes.cpp:21
llvm::StringRef CanonicalPath) {
addRegexMapping((llvm::Twine("^") + llvm::Regex::escape(Path) + "$").str(),
CanonicalPath);
ilya-biryukov added inline comments.
Comment at: clangd/Headers.cpp:60
Argv.push_back(S.c_str());
IgnoringDiagConsumer IgnoreDiags;
auto CI = clang::createInvocationFromCommandLine(
Not related to this patch, but just noticed that we don't call
sammccall added inline comments.
Comment at: clangd/Headers.h:26
///
/// \param Header is an absolute file path.
+/// \return A quoted "path" or . This returns an empty string if:
File also needs to be absolute.
(May want to add asserts for this at the start
ioeric updated this revision to Diff 134932.
ioeric marked 6 inline comments as done.
ioeric added a comment.
- Stop indexing main files in dynamic index; addressed review comments.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D43462
Files:
clangd/ClangdServer.cpp
ioeric added inline comments.
Comment at: clangd/Headers.cpp:45
+bool hasHeaderExtension(PathRef Path) {
+ constexpr static const char *HeaderExtensions[] = {".h", ".hpp", ".hh",
+ ".hxx"};
ilya-biryukov
sammccall added inline comments.
Comment at: clangd/Headers.cpp:42-43
};
+/// Returns true if \p Path has header extensions like .h and .hpp etc.
+bool hasHeaderExtension(PathRef Path) {
As discussed offline, this seems dubious.
- this is probably the
ilya-biryukov added inline comments.
Comment at: clangd/Headers.cpp:45
+bool hasHeaderExtension(PathRef Path) {
+ constexpr static const char *HeaderExtensions[] = {".h", ".hpp", ".hh",
+ ".hxx"};
There is
ioeric created this revision.
ioeric added reviewers: sammccall, ilya-biryukov.
Herald added subscribers: cfe-commits, jkorous-apple, klimek.
o Avoid inserting a header include into the header itself.
o Avoid inserting non-header files.
o Canonicalize include paths for symbols in dynamic index.
15 matches
Mail list logo
