sdardis added a comment.
Thanks for the review.
Repository:
rL LLVM
https://reviews.llvm.org/D43509
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL329167: [libcxx][cmake] Remove libatomic temporarily from
CMAKE_REQUIRED_LIBRARIES when… (authored by sdardis, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://r
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
LGTM.
I would modify the comment to mention that LLVM's configuration may already be
adding `libatomic`
Repository:
rCXX libc++
https://reviews.llvm.org/D43509
sdardis added a comment.
Ping.
Repository:
rCXX libc++
https://reviews.llvm.org/D43509
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sdardis added a comment.
Ping.
Repository:
rCXX libc++
https://reviews.llvm.org/D43509
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sdardis added a comment.
Ping.
Repository:
rCXX libc++
https://reviews.llvm.org/D43509
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sdardis added a comment.
Ping.
Repository:
rCXX libc++
https://reviews.llvm.org/D43509
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sdardis created this revision.
sdardis added a reviewer: EricWF.
Herald added subscribers: christof, mgorny.
When libcxx is built in tree for a host which requires libatomic, LLVM's
configuration steps will determine it is required and add it to
CMAKE_REQUIRED_LIBRARIES. When libcxx is later confi
