[PATCH] D44120: [CFG] [analyzer] Heavier CFGValueTypedCall elements.

2018-03-05 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ updated this revision to Diff 137116. NoQ added a comment. Agreed to rename into `CFGCXXRecordTypedCall`. Because, yeah, `int` is a value as well. https://reviews.llvm.org/D44120 Files: include/clang/Analysis/CFG.h lib/Analysis/CFG.cpp lib/StaticAnalyzer/Core/ExprEngine.cpp lib/Sta

[PATCH] D44120: [CFG] [analyzer] Heavier CFGValueTypedCall elements.

2018-03-05 Thread Devin Coughlin via Phabricator via cfe-commits
dcoughlin accepted this revision. dcoughlin added a comment. This revision is now accepted and ready to land. This looks good to me. I'm not super happy with the name "CFGValueTypedCall" since it doesn't make it obvious that is reflects "a function call that returns a C++ object by value." Is

[PATCH] D44120: [CFG] [analyzer] Heavier CFGValueTypedCall elements.

2018-03-05 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ created this revision. NoQ added reviewers: rsmith, dcoughlin, xazax.hun, a.sidorin, george.karpenkov, szepet. Herald added subscribers: cfe-commits, rnkovacs. https://reviews.llvm.org/D42672 has added extra context to construction calls in the CFG so that the users, such as the analyzer, di