[PATCH] D44217: [clang-tidy] Enable Python 3 support for add_new_check.py

This revision was automatically updated to reflect the committed changes. Closed by commit rL328418: [clang-tidy] Enable Python 3 support for add_new_check.py (authored by jbcoe, committed by ). Herald added subscribers: llvm-commits, klimek. Changed prior to commit:

[PATCH] D44217: [clang-tidy] Enable Python 3 support for add_new_check.py

ilya-biryukov accepted this revision. ilya-biryukov added a comment. This revision is now accepted and ready to land. LGTM. Thanks for the fix! https://reviews.llvm.org/D44217 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D44217: [clang-tidy] Enable Python 3 support for add_new_check.py

jbcoe updated this revision to Diff 137646. https://reviews.llvm.org/D44217 Files: clang-tools-extra/clang-tidy/add_new_check.py Index: clang-tools-extra/clang-tidy/add_new_check.py === ---

[PATCH] D44217: [clang-tidy] Enable Python 3 support for add_new_check.py

ilya-biryukov added inline comments. Comment at: clang-tools-extra/clang-tidy/add_new_check.py:24 with open(filename, 'r') as f: -lines = f.readlines() +lines = [x for x in f.readlines()] `readlines()` returns a list in Python3 too. Maybe remove

[PATCH] D44217: [clang-tidy] Enable Python 3 support for add_new_check.py

jbcoe created this revision. jbcoe added a reviewer: alexfh. Herald added a subscriber: xazax.hun. In Python 3, filters are lazily evaluated and strings are not bytes. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D44217 Files: clang-tools-extra/clang-tidy/add_new_check.py