[PATCH] D44352: [Concepts] Constrained template parameters

2019-04-18 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith requested changes to this revision. rsmith added a comment. This revision now requires changes to proceed. This needs revision to reflect changes between the Concepts TS and C++20. In particular, only the name of a //type-concept// can be used to declare a //template-parameter// in the

[PATCH] D44352: [Concepts] Constrained template parameters

2019-04-16 Thread Balázs Kéri via Phabricator via cfe-commits
balazske added inline comments. Comment at: lib/AST/ASTImporter.cpp:3708 + if (Expr *CE = D->getConstraintExpression()) +R->setConstraintExpression(VisitExpr(CE)); + return R; martong wrote: > Please use the `import` function instead of `VisitExpr`.

[PATCH] D44352: [Concepts] Constrained template parameters

2019-04-16 Thread Gabor Marton via Phabricator via cfe-commits
martong requested changes to this revision. martong added inline comments. This revision now requires changes to proceed. Herald added a subscriber: rnkovacs. Comment at: lib/AST/ASTImporter.cpp:3708 + if (Expr *CE = D->getConstraintExpression()) +

[PATCH] D44352: [Concepts] Constrained template parameters

2018-08-06 Thread Saar Raz via Phabricator via cfe-commits
saar.raz updated this revision to Diff 159378. saar.raz added a comment. Split TryParseConstrainedParameter and ParseConstrainedTemplateParameter in preparation for requries expressions. Repository: rC Clang https://reviews.llvm.org/D44352 Files: include/clang/AST/DeclTemplate.h

[PATCH] D44352: [Concepts] Constrained template parameters

2018-05-16 Thread Saar Raz via Phabricator via cfe-commits
saar.raz updated this revision to Diff 147190. saar.raz added a comment. Adjusted to changes in dependent patches. Repository: rC Clang https://reviews.llvm.org/D44352 Files: include/clang/AST/DeclTemplate.h include/clang/AST/RecursiveASTVisitor.h include/clang/AST/TemplateBase.h

[PATCH] D44352: [Concepts] Constrained template parameters

2018-03-15 Thread Saar Raz via Phabricator via cfe-commits
saar.raz updated this revision to Diff 138537. saar.raz added a comment. Fixed test. Repository: rC Clang https://reviews.llvm.org/D44352 Files: include/clang/AST/DeclTemplate.h include/clang/AST/RecursiveASTVisitor.h include/clang/AST/TemplateBase.h

[PATCH] D44352: [Concepts] Constrained template parameters

2018-03-10 Thread Saar Raz via Phabricator via cfe-commits
saar.raz created this revision. saar.raz added reviewers: nwilson, hubert.reinterpretcast, changyu, rsmith, faisalv, Quuxplusone. Herald added a subscriber: cfe-commits. Added support for constrained template parameters, both simple and with partial template arguments. Depends on