mibintc added inline comments.
Comment at: include/llvm-c/Target.h:25
-#if defined(_MSC_VER) && !defined(inline)
+#if defined(_MSC_VER) && !defined(inline) && !defined(__INTEL_COMPILER)
#define inline __inline
yvvan wrote:
> mibintc wrote:
> > I really think
yvvan added a comment.
In https://reviews.llvm.org/D44426#1042162, @mibintc wrote:
> I added some inline comments. You are using the Intel 18.0 compiler on
> Windows - what version of Visual Studio is in the environment?
Yes, I'm using 18.0
Comment at:
mibintc added a comment.
I added some inline comments. You are using the Intel 18.0 compiler on Windows
- what version of Visual Studio is in the environment?
Comment at: include/llvm-c/Target.h:25
-#if defined(_MSC_VER) && !defined(inline)
+#if defined(_MSC_VER) &&
erichkeane added a comment.
Adding @mibintc to take a look, as she's a good representative of the ICC dev
team.
https://reviews.llvm.org/D44426
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
yvvan added a comment.
@nhaehnle And that's the problem. There's no build machine for intel compiler
and nobody cares.
And if somebody like me want to build it - there's no solution rather than
searching for workarounds yourself.
This patch is not that complex in the end as you see so it should
nhaehnle added a comment.
Is that compiler really supported? Look at this:
void operator delete(void *) = delete;
It's been there in the code since early 2015. The bitwise OR on ELF::xxx has
been there even longer.
Are you telling me that we officially support a compiler, but nobody has
zturner added a comment.
In https://reviews.llvm.org/D44426#1040938, @nhaehnle wrote:
> I don't think we should add workarounds for broken compilers.
I don't follow. What should we do then? If LLVM doesn't compile on a compiler
which we claim is supported, then how should we proceed?
nhaehnle added a comment.
I don't think we should add workarounds for broken compilers.
https://reviews.llvm.org/D44426
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
yvvan created this revision.
yvvan added reviewers: bkramer, klimek.
Herald added subscribers: JDevlieghere, nhaehnle, arsenm.
Herald added a reviewer: deadalnix.
I've tested it on Windows with 64-bit icl
These are mostly workarounds for
https://software.intel.com/en-us/comment/1919743 ,
