[PATCH] D44491: Set dso_local for CFConstantStringClassReference

2018-03-20 Thread Rafael Avila de Espindola via Phabricator via cfe-commits
espindola added a comment. 327993 https://reviews.llvm.org/D44491 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D44491: Set dso_local for CFConstantStringClassReference

2018-03-19 Thread Reid Kleckner via Phabricator via cfe-commits
rnk accepted this revision. rnk added a comment. This revision is now accepted and ready to land. lgtm https://reviews.llvm.org/D44491 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D44491: Set dso_local for CFConstantStringClassReference

2018-03-19 Thread Rafael Avila de Espindola via Phabricator via cfe-commits
espindola added a comment. ping https://reviews.llvm.org/D44491 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D44491: Set dso_local for CFConstantStringClassReference

2018-03-14 Thread Rafael Avila de Espindola via Phabricator via cfe-commits
espindola created this revision. espindola added reviewers: rnk, echristo. This one cannot use setGVProperties since it has special logic for when it is dllimport or not. https://reviews.llvm.org/D44491 Files: lib/CodeGen/CodeGenModule.cpp test/CodeGen/cfstring-windows.c Index: