This revision was automatically updated to reflect the committed changes.
Closed by commit rL331636: [mips] Improve handling of -fno-[pic/PIC] option
(authored by abeserminji, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D44684?vs=145460=145462#toc
Repository:
rL LLVM
abeserminji updated this revision to Diff 145460.
abeserminji marked 4 inline comments as done.
abeserminji added a comment.
Comments resolved.
https://reviews.llvm.org/D44684
Files:
include/clang/Basic/DiagnosticDriverKinds.td
lib/Driver/ToolChains/Arch/Mips.cpp
sdardis accepted this revision.
sdardis added a comment.
This revision is now accepted and ready to land.
LGTM, with a touch up of the error message to match the others we have
regarding -mabicalls. Some other minor nits inlined.
Comment at:
abeserminji updated this revision to Diff 144344.
abeserminji marked 2 inline comments as done.
abeserminji added a comment.
Comments resolved.
https://reviews.llvm.org/D44684
Files:
include/clang/Basic/DiagnosticDriverKinds.td
lib/Driver/ToolChains/Arch/Mips.cpp
abeserminji added inline comments.
Comment at: include/clang/Basic/DiagnosticDriverKinds.td:340
+ "ignoring '%0' option as it cannot be used with "
+ "explicit use of -mabicalls and the N64 ABI">,
InGroup;
sdardis wrote:
> Use the
sdardis added inline comments.
Comment at: include/clang/Basic/DiagnosticDriverKinds.td:340
+ "ignoring '%0' option as it cannot be used with "
+ "explicit use of -mabicalls and the N64 ABI">,
InGroup;
Use the %select{optionA|optionB|..|optionZ}$NUM
abeserminji updated this revision to Diff 144092.
abeserminji added a comment.
Comments resolved.
Repository:
rL LLVM
https://reviews.llvm.org/D44684
Files:
include/clang/Basic/DiagnosticDriverKinds.td
lib/Driver/ToolChains/Arch/Mips.cpp
lib/Driver/ToolChains/CommonArgs.cpp
sdardis requested changes to this revision.
sdardis added a comment.
This revision now requires changes to proceed.
A quick comment on the error message, inlined. It's about the quality of the
diagnostics.
Comment at: include/clang/Basic/DiagnosticDriverKinds.td:336-337
+def
abeserminji created this revision.
abeserminji added reviewers: petarj, sdardis.
Herald added subscribers: llvm-commits, arichardson.
- On N64 ABI, -mno-abicalls is needed to disable PIC. Warning is reported when
only -fno-pic/-fno-PIC is used. This is how GCC behaves.
- An error is reported
