[PATCH] D44727: [RISCV] Implement getTargetDefines, handleTargetFeatures and hasFeature for RISCVTargetInfo

2018-03-27 Thread Ana Pazos via Phabricator via cfe-commits
apazos added inline comments. Comment at: test/Preprocessor/riscv-target-features.c:9 + +// RUN: %clang -target riscv32-unknown-linux-gnu -march=rv32im -x c -E -dM %s -o - | FileCheck --check-prefix=CHECK-M-EXT %s +// RUN: %clang -target riscv64-unknown-linux-gnu -march=rv64im

[PATCH] D44727: [RISCV] Implement getTargetDefines, handleTargetFeatures and hasFeature for RISCVTargetInfo

2018-03-22 Thread Alex Bradbury via Phabricator via cfe-commits
asb added subscribers: doug.gregor, rsmith. asb added a comment. Thanks Kito. I've added some comments inline. Nitpicking: the patch description would be more accurate to say it "extends getTargetDefines", as obviously an initial implementation was already present Comment

[PATCH] D44727: [RISCV] Implement getTargetDefines, handleTargetFeatures and hasFeature for RISCVTargetInfo

2018-03-20 Thread Kito Cheng via Phabricator via cfe-commits
kito-cheng created this revision. kito-cheng added reviewers: asb, apazos. Herald added subscribers: cfe-commits, shiva0217, niosHD, sabuasal, jordy.potman.lists, simoncook, johnrusso, rbar. kito-cheng added a dependency: D44189: [RISCV] Verify the input value of -march=. This patch implement