This revision was automatically updated to reflect the committed changes.
Closed by commit rL329804: [Sema] Fix built-in decrement operator overload
resolution (authored by jkorous, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
vsapsai accepted this revision.
vsapsai added a comment.
This revision is now accepted and ready to land.
Looks good to me.
https://reviews.llvm.org/D44988
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
jkorous-apple added a comment.
Spot on with the negative test idea! Should've done that myself. Thanks.
https://reviews.llvm.org/D44988
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
jkorous-apple updated this revision to Diff 141865.
jkorous-apple added a comment.
Added test for decrement being disabled for bool.
Fixed comment in test (will put into separate NFC commit).
https://reviews.llvm.org/D44988
Files:
Sema/SemaOverload.cpp
vsapsai added inline comments.
Comment at: test/SemaCXX/overloaded-builtin-operators.cpp:95-99
// C++ [over.built]p3
long l1 = lr--;
+ // C++ [over.built]p4
+ float f1 = fr--;
Looks like p3 for `lr--` is a typo because p3 is about `++` while p4 is
jkorous-apple created this revision.
jkorous-apple added reviewers: speziale.ettore, arphaman.
Herald added a subscriber: cfe-commits.
C++ [over.built]p4:
For every pair (T, VQ), where T is an arithmetic type other than bool, and VQ
is either volatile or empty, there exist candidate operator
