whisperity added a comment.
Akin to https://reviews.llvm.org/D45094, pinging this too.
https://reviews.llvm.org/D45095
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
whisperity added inline comments.
Comment at: clang-tidy/tool/CMakeLists.txt:19
clangBasic
+ clangFrontend
clangTidy
ilya-biryukov wrote:
> whisperity wrote:
> > ilya-biryukov wrote:
> > > Why do we need an extra dependency?
> > In the current state of
ilya-biryukov added inline comments.
Comment at: clang-tidy/ClangTidy.cpp:91
public:
- ErrorReporter(ClangTidyContext , bool ApplyFixes,
-llvm::IntrusiveRefCntPtr BaseFS)
- : Files(FileSystemOptions(), BaseFS), DiagOpts(new DiagnosticOptions()),
+
whisperity added inline comments.
Comment at: clang-tidy/ClangTidy.cpp:91
public:
- ErrorReporter(ClangTidyContext , bool ApplyFixes,
-llvm::IntrusiveRefCntPtr BaseFS)
- : Files(FileSystemOptions(), BaseFS), DiagOpts(new DiagnosticOptions()),
+
ilya-biryukov added subscribers: hokein, alexfh.
ilya-biryukov added inline comments.
Comment at: clang-tidy/ClangTidy.cpp:91
public:
- ErrorReporter(ClangTidyContext , bool ApplyFixes,
-llvm::IntrusiveRefCntPtr BaseFS)
- : Files(FileSystemOptions(),
whisperity updated this revision to Diff 141207.
whisperity added a comment.
Update to be in line with contents in dependency patch.
https://reviews.llvm.org/D45095
Files:
clang-tidy/ClangTidy.cpp
clang-tidy/ClangTidy.h
clang-tidy/tool/CMakeLists.txt
clang-tidy/tool/ClangTidyMain.cpp
