[PATCH] D45149: MallocChecker, adding specific BSD calls

2018-05-02 Thread David CARLIER via Phabricator via cfe-commits
devnexen added a comment. In https://reviews.llvm.org/D45149#1062279, @jdenny wrote: > Hi David. While I did make some superficial changes here recently, I'm no > authority on what belongs here. However, I would suggest that the > refactoring patch be split from the original patch. Thanks.

[PATCH] D45149: MallocChecker, adding specific BSD calls

2018-05-02 Thread Kamil Rytarowski via Phabricator via cfe-commits
krytarowski added a comment. These calls are not 'BSD' specific.. but OpenBSD. https://reviews.llvm.org/D45149 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D45149: MallocChecker, adding specific BSD calls

2018-04-09 Thread Joel E. Denny via Phabricator via cfe-commits
jdenny added a comment. Hi David. While I did make some superficial changes here recently, I'm no authority on what belongs here. However, I would suggest that the refactoring patch be split from the original patch. Thanks. https://reviews.llvm.org/D45149

[PATCH] D45149: MallocChecker, adding specific BSD calls

2018-04-09 Thread David CARLIER via Phabricator via cfe-commits
devnexen added a comment. ping https://reviews.llvm.org/D45149 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D45149: MallocChecker, adding specific BSD calls

2018-04-02 Thread David CARLIER via Phabricator via cfe-commits
devnexen updated this revision to Diff 140607. devnexen added a comment. Using groups of functions. https://reviews.llvm.org/D45149 Files: lib/StaticAnalyzer/Checkers/MallocChecker.cpp test/Analysis/bsd-malloc.c Index: test/Analysis/bsd-malloc.c

[PATCH] D45149: MallocChecker, adding specific BSD calls

2018-04-01 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added a comment. Nice, thanks. Comment at: lib/StaticAnalyzer/Checkers/MallocChecker.cpp:662-676 if (Family == AF_Malloc && CheckAlloc) { if (FunI == II_malloc || FunI == II_realloc || FunI == II_reallocf || FunI == II_calloc || FunI == II_valloc ||

[PATCH] D45149: MallocChecker, adding specific BSD calls

2018-04-01 Thread David CARLIER via Phabricator via cfe-commits
devnexen created this revision. devnexen added reviewers: NoQ, jdenny. Herald added a subscriber: cfe-commits. - reallocarray/recallocarray - freezero Repository: rC Clang https://reviews.llvm.org/D45149 Files: lib/StaticAnalyzer/Checkers/MallocChecker.cpp test/Analysis/bsd-malloc.c