[PATCH] D45241: [analyzer] Invalidate union regions properly. Don't hesitate to load the default binding later.

2018-05-04 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC331563: [analyzer] Invalidate union regions properly. Dont hesitate to load later. (authored by dergachev, committed by ). Herald added a subscriber: baloghadamsoftware. Repository: rC Clang

[PATCH] D45241: [analyzer] Invalidate union regions properly. Don't hesitate to load the default binding later.

2018-04-08 Thread Aleksei Sidorin via Phabricator via cfe-commits
a.sidorin accepted this revision. a.sidorin added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rC Clang https://reviews.llvm.org/D45241 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D45241: [analyzer] Invalidate union regions properly. Don't hesitate to load the default binding later.

2018-04-03 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ added inline comments. Comment at: test/Analysis/unions.cpp:82 uu = vv; -// FIXME: Should be true. -clang_analyzer_eval(uu.i == 5); // expected-warning{{UNKNOWN}} +clang_analyzer_eval(uu.i == 5); // expected-warning{{TRUE}} } This test

[PATCH] D45241: [analyzer] Invalidate union regions properly. Don't hesitate to load the default binding later.

2018-04-03 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a.sidorin, george.karpenkov, szepet. Herald added subscribers: cfe-commits, rnkovacs. (1) We weren't invalidating our unions correctly. The previous behavior in `invalidateRegionsWorker::VisitCluster()` was to //direct//-bind