a.sidorin closed this revision.
a.sidorin added a comment.
Closed with https://reviews.llvm.org/rC330605. Forgot to mention the
Differential Revision, sorry.
Repository:
rC Clang
https://reviews.llvm.org/D45417
___
cfe-commits mailing list
george.karpenkov added a comment.
> I have removed the FIXME at all
Repository:
rC Clang
https://reviews.llvm.org/D45417
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
a.sidorin updated this revision to Diff 141870.
a.sidorin added a comment.
Renamed the test file.
Repository:
rC Clang
https://reviews.llvm.org/D45417
Files:
lib/StaticAnalyzer/Core/SVals.cpp
test/Analysis/sval-dump-int128.c
Index: test/Analysis/sval-dump-int128.c
a.sidorin updated this revision to Diff 141869.
a.sidorin edited the summary of this revision.
a.sidorin added a comment.
After thinking a bit more, I have removed the FIXME at all: dumping SVal is an
extremely rare event so this shouldn't affect the performance.
Repository:
rC Clang
NoQ added inline comments.
Comment at: test/Analysis/egraph-dump-int128.c:3
+// RUN: mkdir -p %t.dir
+// RUN: env TMPDIR=%t.dir TEMP=%t.dir TMP=%t.dir %clang_analyze_cc1
-analyzer-checker=debug.ViewExplodedGraph %s
+
george.karpenkov wrote:
> At least on a mac,
george.karpenkov added inline comments.
Comment at: lib/StaticAnalyzer/Core/SVals.cpp:304
const nonloc::ConcreteInt& C = castAs();
- if (C.getValue().isUnsigned())
-os << C.getValue().getZExtValue();
- else
-os << C.getValue().getSExtValue();
-
a.sidorin created this revision.
a.sidorin added reviewers: NoQ, dcoughlin, xazax.hun.
Herald added subscribers: cfe-commits, rnkovacs, szepet.
Herald added a reviewer: george.karpenkov.
Printing of ConcreteInts with size >64 bits resulted in assertion failure in
get[Z|S]ExtValue()
