[PATCH] D45650: [CFG] [analyzer] Don't treat argument constructors as temporary constructors.

2018-04-19 Thread Phabricator via Phabricator via cfe-commits
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL330377: [CFG] [analyzer] Don't treat argument constructors as temporary constructors. (authored by dergachev, committed by

[PATCH] D45650: [CFG] [analyzer] Don't treat argument constructors as temporary constructors.

2018-04-19 Thread Phabricator via Phabricator via cfe-commits
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rC330377: [CFG] [analyzer] Don't treat argument constructors as temporary constructors. (authored by dergachev, committed by

[PATCH] D45650: [CFG] [analyzer] Don't treat argument constructors as temporary constructors.

2018-04-13 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ updated this revision to Diff 142505. NoQ added a comment. Add tests where the argument is passed by reference. These tests work correctly (i.e. they correctly identify the argument constructor as a temporary constructor) because such constructors would include a `MaterializeTemporaryExpr`

[PATCH] D45650: [CFG] [analyzer] Don't treat argument constructors as temporary constructors.

2018-04-13 Thread Artem Dergachev via Phabricator via cfe-commits
NoQ created this revision. NoQ added reviewers: dcoughlin, xazax.hun, a.sidorin, george.karpenkov, szepet. Herald added subscribers: cfe-commits, rnkovacs. Function argument constructors (that are used for passing objects into functions by value) are completely unlike temporary object constructor