This revision was automatically updated to reflect the committed changes.
Closed by commit rL338931: Diagnose invalid cv-qualifiers for friend decls.
(authored by efriedma, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
efriedma added a comment.
Herald added a subscriber: jfb.
Ping
Repository:
rC Clang
https://reviews.llvm.org/D45712
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
efriedma added a comment.
Ping
Repository:
rC Clang
https://reviews.llvm.org/D45712
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
efriedma updated this revision to Diff 154707.
efriedma edited the summary of this revision.
efriedma added a comment.
Move declspec checks before call to GetTypeForDeclarator, since it can fail for
class templates.
Repository:
rC Clang
https://reviews.llvm.org/D45712
Files:
efriedma added a comment.
I thought the template case wasn't using the same codepath, but apparently I
was just confusing myself. The exact form "template friend class
Y;" triggers an early out in Sema::ActOnFriendTypeDecl, so my code wasn't
getting hit. I'll revise accordingly.
rsmith added a comment.
Can we avoid the duplication by putting this check in
`Sema::ParsedFreeStandingDeclSpec` instead?
Repository:
rC Clang
https://reviews.llvm.org/D45712
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
efriedma updated this revision to Diff 154471.
efriedma retitled this revision from "[WIP] Diagnose invalid cv-qualifiers for
friend decls." to "Diagnose invalid cv-qualifiers for friend decls.".
efriedma edited the summary of this revision.
efriedma added a comment.
Updated to handle the
