This revision was automatically updated to reflect the committed changes.
Closed by commit rL330220: [XRay] Add clang builtin for xray typed events.
(authored by kpw, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D45716
Files:
cfe/trunk/include/clang/Basic/Builtins.def
cfe
This revision was automatically updated to reflect the committed changes.
Closed by commit rC330220: [XRay] Add clang builtin for xray typed events.
(authored by kpw, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D45716?vs=142790&id=142836#toc
Repository:
rC Clang
https:
kpw updated this revision to Diff 142790.
kpw added a comment.
Undoing formatting change.
Repository:
rC Clang
https://reviews.llvm.org/D45716
Files:
include/clang/Basic/Builtins.def
include/clang/Basic/LangOptions.def
include/clang/Basic/XRayInstr.h
include/clang/Driver/Options.td
dberris accepted this revision.
dberris added a comment.
This revision is now accepted and ready to land.
In https://reviews.llvm.org/D45716#1069567, @dberris wrote:
> In https://reviews.llvm.org/D45716#1069557, @kpw wrote:
>
> > My editor got a bit carried away with automatically clang-formattin
dberris added a comment.
In https://reviews.llvm.org/D45716#1069557, @kpw wrote:
> My editor got a bit carried away with automatically clang-formatting
> lib/CodeGen/CodeGenFunction.cpp. I'll fix that so that I'm not messing up the
> revision history.
Yes please. :)
Also, if you can add to t
kpw added a comment.
My editor got a bit carried away with automatically clang-formatting
lib/CodeGen/CodeGenFunction.cpp. I'll fix that so that I'm not messing up the
revision history.
Repository:
rC Clang
https://reviews.llvm.org/D45716
___
c
kpw updated this revision to Diff 142737.
kpw added a comment.
Added flags and bundle options.
Repository:
rC Clang
https://reviews.llvm.org/D45716
Files:
include/clang/Basic/Builtins.def
include/clang/Basic/LangOptions.def
include/clang/Basic/XRayInstr.h
include/clang/Driver/Options
kpw added inline comments.
Comment at: test/CodeGen/xray-typedevent.cpp:10
+ __xray_typedevent(EventType, kPhase, 10);
+ // CHECK: call void @llvm.xray.typedevent(i16 {{.*}}, i8*{{.*}}, i32 10)
+}
FYI: It would be involved to match on more than * for the event
dberris requested changes to this revision.
dberris added a comment.
This revision now requires changes to proceed.
Thanks, Keith -- we're going to need to add this to the list of instrumentation
points we can enable/disable through flags.
Comment at: lib/CodeGen/CGBuiltin.cpp
kpw updated this revision to Diff 142735.
kpw added a comment.
Adding a comment to the test to encourage getting the event types from
compiler-rt
Repository:
rC Clang
https://reviews.llvm.org/D45716
Files:
include/clang/Basic/Builtins.def
lib/CodeGen/CGBuiltin.cpp
test/CodeGen/xray-typ
kpw created this revision.
kpw added reviewers: dberris, pelikan, rnk, eizan.
A clang builtin for xray typed events. Differs from
__xray_customevent(...) by the presence of a type tag that is vended by
compiler-rt in typical usage. This allows xray handlers to expand logged
events with their type
11 matches
Mail list logo